Fix eslint warnings

thecodewarrior · thecodewarrior · commit ec58c6238d93 · 2021-12-05T09:51:48.000-08:00
diff --git a/src/Tippy.ts b/src/Tippy.ts
@@ -30,10 +30,12 @@ export default defineComponent({
     ...commonVisibleProp,
     ...commonProps
   },
+  /* eslint-disable @typescript-eslint/no-unused-vars */
   emits: {
     attach: (instance: TippyInstance) => true,
     ...commonEmits
   },
+  /* eslint-enable @typescript-eslint/no-unused-vars */
   render() {
     return h('div', {
       'tippy-missing-target': this.tippyTargetMissing ? '' : undefined,
@@ -57,13 +59,10 @@ export default defineComponent({
     attach() {
       // destroy old tip
       if (this.tip) {
-        try {
-          this.singletonInstance?.remove(this.tip)
-          this.tip.destroy();
-        } catch (error) {
-          console.error(error)
-        }
-        this.tip = undefined;
+        const tip = this.tip
+        this.tip = undefined
+        this.singletonInstance?.remove(tip)
+        tip.destroy();
       }
 
       // find the target
diff --git a/src/TippyDirective.ts b/src/TippyDirective.ts
@@ -1,5 +1,5 @@
 import tippy, {Instance as TippyInstance, Props} from "tippy.js";
-import {Directive, DirectiveBinding, VNode} from "vue";
+import {Directive, DirectiveBinding} from "vue";
 
 const _mode = Symbol("v-tippy mode")
 type VTippyMode = 'inline' | 'target'
diff --git a/src/TippySingleton.ts b/src/TippySingleton.ts
@@ -1,4 +1,4 @@
-import {defineComponent, h, PropType, ref, toRefs} from "vue";
+import {defineComponent, h, PropType, ref} from "vue";
 import {commonEmits, commonProps, commonSetup} from "./common";
 import {
   createSingleton,
@@ -45,11 +45,13 @@ export default defineComponent({
     },
     ...commonProps
   },
+  /* eslint-disable @typescript-eslint/no-unused-vars */
   emits: {
     add: (instance: TippyInstance) => true,
     remove: (instance: TippyInstance) => true,
     ...commonEmits
   },
+  /* eslint-enable @typescript-eslint/no-unused-vars */
   render() {
     return h('div', {
       'style': 'display: none;',
diff --git a/src/common.ts b/src/common.ts
@@ -3,6 +3,7 @@ import {computed, ExtractPropTypes, PropType, Ref, toRefs, watch} from "vue";
 import {SetupContext} from "@vue/runtime-core";
 import {injectCallback} from "./utils";
 
+/* eslint-disable @typescript-eslint/no-unused-vars */
 export const commonEmits = {
   mount: (instance: TippyInstance) => true,
   show: (instance: TippyInstance) => true,
@@ -12,6 +13,7 @@ export const commonEmits = {
   trigger: (instance: TippyInstance, event: Event) => true,
   untrigger: (instance: TippyInstance, event: Event) => true,
 }
+/* eslint-enable @typescript-eslint/no-unused-vars */
 
 export const commonProps = {
   /**
diff --git a/src/utils.ts b/src/utils.ts
@@ -54,7 +54,3 @@ export function findSibling(element: Element, test: (element: Element) => boolea
   }
   return null;
 }
-
-function matchesTarget(element: any, dataName: string, dataValue: string): boolean {
-  return element.dataset && element.dataset[dataName] === dataValue
-}

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,3 @@ export function findSibling(element: Element, test: (element: Element) => boolea`
`54`	`54`	`}`
`55`	`55`	`return null;`
`56`	`56`	`}`
`57`		`-`
`58`		`-function matchesTarget(element: any, dataName: string, dataValue: string): boolean {`
`59`		`- return element.dataset && element.dataset[dataName] === dataValue`
`60`		`-}`