Skip to content

Commit ae93580

Browse files
committed
drm/radeon: fix dpms when driver backlight control is disabled
If driver backlight control is disabled, either by driver parameter or default per-asic setting, revert to the old behavior. Fixes a regression in commit: 4281f46 Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org
1 parent 4cee6a9 commit ae93580

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

drivers/gpu/drm/radeon/atombios_encoders.c

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1625,9 +1625,14 @@ radeon_atom_encoder_dpms_avivo(struct drm_encoder *encoder, int mode)
16251625
} else
16261626
atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args);
16271627
if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
1628-
struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;
1628+
if (rdev->mode_info.bl_encoder) {
1629+
struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;
16291630

1630-
atombios_set_backlight_level(radeon_encoder, dig->backlight_level);
1631+
atombios_set_backlight_level(radeon_encoder, dig->backlight_level);
1632+
} else {
1633+
args.ucAction = ATOM_LCD_BLON;
1634+
atom_execute_table(rdev->mode_info.atom_context, index, (uint32_t *)&args);
1635+
}
16311636
}
16321637
break;
16331638
case DRM_MODE_DPMS_STANDBY:
@@ -1707,8 +1712,13 @@ radeon_atom_encoder_dpms_dig(struct drm_encoder *encoder, int mode)
17071712
if (ASIC_IS_DCE4(rdev))
17081713
atombios_dig_encoder_setup(encoder, ATOM_ENCODER_CMD_DP_VIDEO_ON, 0);
17091714
}
1710-
if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT))
1711-
atombios_set_backlight_level(radeon_encoder, dig->backlight_level);
1715+
if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
1716+
if (rdev->mode_info.bl_encoder)
1717+
atombios_set_backlight_level(radeon_encoder, dig->backlight_level);
1718+
else
1719+
atombios_dig_transmitter_setup(encoder,
1720+
ATOM_TRANSMITTER_ACTION_LCD_BLON, 0, 0);
1721+
}
17121722
if (ext_encoder)
17131723
atombios_external_encoder_setup(encoder, ext_encoder, ATOM_ENABLE);
17141724
break;

0 commit comments

Comments
 (0)