Skip to content

Commit fbb4574

Browse files
mrutland-armchazy
authored andcommitted
arm64: kvm: report original PAR_EL1 upon panic
If we call __kvm_hyp_panic while a guest context is active, we call __restore_sysregs before acquiring the system register values for the panic, in the process throwing away the PAR_EL1 value at the point of the panic. This patch modifies __kvm_hyp_panic to stash the PAR_EL1 value prior to restoring host register values, enabling us to report the original values at the point of the panic. Acked-by: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
1 parent 1d7a4e3 commit fbb4574

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

arch/arm64/kvm/hyp.S

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -864,6 +864,10 @@ ENTRY(__kvm_flush_vm_context)
864864
ENDPROC(__kvm_flush_vm_context)
865865

866866
__kvm_hyp_panic:
867+
// Stash PAR_EL1 before corrupting it in __restore_sysregs
868+
mrs x0, par_el1
869+
push x0, xzr
870+
867871
// Guess the context by looking at VTTBR:
868872
// If zero, then we're already a host.
869873
// Otherwise restore a minimal host context before panicing.
@@ -898,7 +902,7 @@ __kvm_hyp_panic:
898902
mrs x3, esr_el2
899903
mrs x4, far_el2
900904
mrs x5, hpfar_el2
901-
mrs x6, par_el1
905+
pop x6, xzr // active context PAR_EL1
902906
mrs x7, tpidr_el2
903907

904908
mov lr, #(PSR_F_BIT | PSR_I_BIT | PSR_A_BIT | PSR_D_BIT |\

0 commit comments

Comments
 (0)