Check botocore version when activating integration (getsentry#921)

marshall-lee · untitaker · web-flow · commit 5a41127ef2b3 · 2020-11-19T11:09:57.000+01:00
Co-authored-by: Markus Unterwaditzer &lt;markus-honeypot@unterwaditzer.net&gt;
diff --git a/sentry_sdk/integrations/boto3.py b/sentry_sdk/integrations/boto3.py
@@ -14,6 +14,7 @@
     from typing import Type
 
 try:
+    from botocore import __version__ as BOTOCORE_VERSION  # type: ignore
     from botocore.client import BaseClient  # type: ignore
     from botocore.response import StreamingBody  # type: ignore
     from botocore.awsrequest import AWSRequest  # type: ignore
@@ -27,6 +28,14 @@ class Boto3Integration(Integration):
     @staticmethod
     def setup_once():
         # type: () -> None
+        try:
+            version = tuple(map(int, BOTOCORE_VERSION.split(".")[:3]))
+        except (ValueError, TypeError):
+            raise DidNotEnable(
+                "Unparsable botocore version: {}".format(BOTOCORE_VERSION)
+            )
+        if version < (1, 12):
+            raise DidNotEnable("Botocore 1.12 or newer is required.")
         orig_init = BaseClient.__init__
 
         def sentry_patched_init(self, *args, **kwargs):
diff --git a/tox.ini b/tox.ini
@@ -83,7 +83,7 @@ envlist =
 
     {py3.6,py3.7,py3.8}-chalice-{1.16,1.17,1.18,1.19,1.20}
 
-    {py2.7,py3.6,py3.7,py3.8}-boto3-{1.14,1.15,1.16}
+    {py2.7,py3.6,py3.7,py3.8}-boto3-{1.9,1.10,1.11,1.12,1.13,1.14,1.15,1.16}
 
 [testenv]
 deps =
@@ -234,6 +234,11 @@ deps =
     chalice-1.20: chalice>=1.20.0,<1.21.0
     chalice: pytest-chalice==0.0.5
 
+    boto3-1.9: boto3>=1.9,<1.10
+    boto3-1.10: boto3>=1.10,<1.11
+    boto3-1.11: boto3>=1.11,<1.12
+    boto3-1.12: boto3>=1.12,<1.13
+    boto3-1.13: boto3>=1.13,<1.14
     boto3-1.14: boto3>=1.14,<1.15
     boto3-1.15: boto3>=1.15,<1.16
     boto3-1.16: boto3>=1.16,<1.17
