Used settings fixture instead of importing django settings (getsentry#1038)

ahmedetefy · web-flow · commit b9cdcd60c9f8 · 2021-03-02T11:02:51.000+01:00
diff --git a/tests/integrations/django/test_basic.py b/tests/integrations/django/test_basic.py
@@ -41,14 +41,12 @@ def test_view_exceptions(sentry_init, client, capture_exceptions, capture_events
 
 
 def test_ensures_x_forwarded_header_is_honored_in_sdk_when_enabled_in_django(
-    sentry_init, client, capture_exceptions, capture_events
+    sentry_init, client, capture_exceptions, capture_events, settings
 ):
     """
     Test that ensures if django settings.USE_X_FORWARDED_HOST is set to True
     then the SDK sets the request url to the `HTTP_X_FORWARDED_FOR`
     """
-    from django.conf import settings
-
     settings.USE_X_FORWARDED_HOST = True
 
     sentry_init(integrations=[DjangoIntegration()], send_default_pii=True)
@@ -62,8 +60,6 @@ def test_ensures_x_forwarded_header_is_honored_in_sdk_when_enabled_in_django(
     (event,) = events
     assert event["request"]["url"] == "http://example.com/view-exc"
 
-    settings.USE_X_FORWARDED_HOST = False
-
 
 def test_ensures_x_forwarded_header_is_not_honored_when_unenabled_in_django(
     sentry_init, client, capture_exceptions, capture_events
