No need to unref timers

porsager · porsager · commit 01c2c68c842e · 2022-04-19T13:23:06.000+02:00
diff --git a/src/connection.js b/src/connection.js
@@ -1011,7 +1011,7 @@ function timer(fn, seconds) {
     },
     start() {
       timer && clearTimeout(timer)
-      timer = setTimeout(done, seconds * 1000, arguments).unref()
+      timer = setTimeout(done, seconds * 1000, arguments)
     }
   }
 
diff --git a/transpile.deno.js b/transpile.deno.js
@@ -79,10 +79,6 @@ function transpile(x, name, folder) {
     : ''
 
   return hmac + buffer + process + stream + timers + x
-    .replace(
-      /setTimeout\((.*)\)\.unref\(\)/g,
-      '(window.timer = setTimeout($1), Deno.unrefTimer(window.timer), window.timer)'
-    )
     .replace(
       'crypto.createHmac(\'sha256\', key).update(x).digest()',
       'Buffer.from(new HmacSha256(key).update(x).digest())'
@@ -92,7 +88,6 @@ function transpile(x, name, folder) {
       '(query.writable.push({ chunk }), callback())'
     )
     .replace(/.setKeepAlive\([^)]+\)/g, '')
-    .replace(/import\('node:stream'\)\./g, '')
     .replace(/import net from 'net'/, 'import { net } from \'../polyfills.js\'')
     .replace(/import tls from 'tls'/, 'import { tls } from \'../polyfills.js\'')
     .replace(/ from '([a-z_]+)'/g, ' from \'' + std + 'node/$1.ts\'')

Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,7 @@ function timer(fn, seconds) {`
`1011`	`1011`	`},`
`1012`	`1012`	`start() {`
`1013`	`1013`	`timer && clearTimeout(timer)`
`1014`		`- timer = setTimeout(done, seconds * 1000, arguments).unref()`
	`1014`	`+ timer = setTimeout(done, seconds * 1000, arguments)`
`1015`	`1015`	`}`
`1016`	`1016`	`}`
`1017`	`1017`