Fix porsager#188 Support escaping dynamic schemas and tables

porsager · porsager · commit 2e3652b2cf0b · 2021-06-18T08:50:28.000+02:00
diff --git a/lib/types.js b/lib/types.js
@@ -66,7 +66,7 @@ function typeHandlers(types) {
 }
 
 module.exports.escape = function escape(str) {
-  return '"' + str.replace(/"/g, '""') + '"'
+  return '"' + str.replace(/"/g, '""').replace(/\./g, '"."') + '"'
 }
 
 const type = {
diff --git a/tests/index.js b/tests/index.js
@@ -1278,3 +1278,15 @@ t('Multiple hosts', {
 
   return ['5432,5433,5432', result.join(',')]
 })
+
+t('Escaping supports schemas and tables', async() => {
+  await sql`create schema a`
+  await sql`create table a.b (c int)`
+  await sql`insert into a.b (c) values (1)`
+  return [
+    1,
+    (await sql`select ${ sql('a.b.c') } from a.b`)[0].c,
+    await sql`drop table a.b`,
+    await sql`drop schema a`
+  ]
+})

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ function typeHandlers(types) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`module.exports.escape = function escape(str) {`
`69`		`- return '"' + str.replace(/"/g, '""') + '"'`
	`69`	`+ return '"' + str.replace(/"/g, '""').replace(/\./g, '"."') + '"'`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`const type = {`