Fix dynamic in helper after insert porsager#305

porsager · porsager · commit 4d63a59ad0e5 · 2022-04-06T14:55:31.000+02:00
diff --git a/cjs/src/types.js b/cjs/src/types.js
@@ -145,7 +145,7 @@ const builders = Object.entries({
     ).join(',') + ')values' +
     valuesBuilder(Array.isArray(first) ? first : [first], parameters, types, transform, columns)
   }
-}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x, 'i'), fn]))
+}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x + '($|[\\s(])', 'i'), fn]))
 
 function notTagged() {
   throw Errors.generic('NOT_TAGGED_CALL', 'Query not called as a tagged template literal')
diff --git a/cjs/tests/index.js b/cjs/tests/index.js
@@ -893,6 +893,21 @@ t('dynamic insert pluck', async() => {
   return [null, (await sql`insert into test ${ sql(x, 'a') } returning *`)[0].b, await sql`drop table test`]
 })
 
+t('dynamic in after insert', async() => {
+  await sql`create table test (a int, b text)`
+  const [{ x }] = await sql`
+    with x as (
+      insert into test values (1, 'hej')
+      returning *
+    )
+    select 1 in ${ sql([1, 2, 3]) } as x from x
+  `
+  return [
+    true, x,
+    await sql`drop table test`
+  ]
+})
+
 t('array insert', async() => {
   await sql`create table test (a int, b int)`
   return [2, (await sql`insert into test (a, b) values ${ sql([1, 2]) } returning *`)[0].b, await sql`drop table test`]
diff --git a/deno/src/types.js b/deno/src/types.js
@@ -146,7 +146,7 @@ const builders = Object.entries({
     ).join(',') + ')values' +
     valuesBuilder(Array.isArray(first) ? first : [first], parameters, types, transform, columns)
   }
-}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x, 'i'), fn]))
+}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x + '($|[\\s(])', 'i'), fn]))
 
 function notTagged() {
   throw Errors.generic('NOT_TAGGED_CALL', 'Query not called as a tagged template literal')
diff --git a/deno/tests/index.js b/deno/tests/index.js
@@ -895,6 +895,21 @@ t('dynamic insert pluck', async() => {
   return [null, (await sql`insert into test ${ sql(x, 'a') } returning *`)[0].b, await sql`drop table test`]
 })
 
+t('dynamic in after insert', async() => {
+  await sql`create table test (a int, b text)`
+  const [{ x }] = await sql`
+    with x as (
+      insert into test values (1, 'hej')
+      returning *
+    )
+    select 1 in ${ sql([1, 2, 3]) } as x from x
+  `
+  return [
+    true, x,
+    await sql`drop table test`
+  ]
+})
+
 t('array insert', async() => {
   await sql`create table test (a int, b int)`
   return [2, (await sql`insert into test (a, b) values ${ sql([1, 2]) } returning *`)[0].b, await sql`drop table test`]
diff --git a/src/types.js b/src/types.js
@@ -145,7 +145,7 @@ const builders = Object.entries({
     ).join(',') + ')values' +
     valuesBuilder(Array.isArray(first) ? first : [first], parameters, types, transform, columns)
   }
-}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x, 'i'), fn]))
+}).map(([x, fn]) => ([new RegExp('(^|[\\s(])' + x + '($|[\\s(])', 'i'), fn]))
 
 function notTagged() {
   throw Errors.generic('NOT_TAGGED_CALL', 'Query not called as a tagged template literal')
diff --git a/tests/index.js b/tests/index.js
@@ -893,6 +893,21 @@ t('dynamic insert pluck', async() => {
   return [null, (await sql`insert into test ${ sql(x, 'a') } returning *`)[0].b, await sql`drop table test`]
 })
 
+t('dynamic in after insert', async() => {
+  await sql`create table test (a int, b text)`
+  const [{ x }] = await sql`
+    with x as (
+      insert into test values (1, 'hej')
+      returning *
+    )
+    select 1 in ${ sql([1, 2, 3]) } as x from x
+  `
+  return [
+    true, x,
+    await sql`drop table test`
+  ]
+})
+
 t('array insert', async() => {
   await sql`create table test (a int, b int)`
   return [2, (await sql`insert into test (a, b) values ${ sql([1, 2]) } returning *`)[0].b, await sql`drop table test`]

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ const builders = Object.entries({`
`145`	`145`	`).join(',') + ')values' +`
`146`	`146`	`valuesBuilder(Array.isArray(first) ? first : [first], parameters, types, transform, columns)`
`147`	`147`	`}`
`148`		`-}).map(([x, fn]) => ([new RegExp('(^\|[\\s(])' + x, 'i'), fn]))`
	`148`	`+}).map(([x, fn]) => ([new RegExp('(^\|[\\s(])' + x + '($\|[\\s(])', 'i'), fn]))`
`149`	`149`
`150`	`150`	`function notTagged() {`
`151`	`151`	`throw Errors.generic('NOT_TAGGED_CALL', 'Query not called as a tagged template literal')`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ const builders = Object.entries({`
`146`	`146`	`).join(',') + ')values' +`
`147`	`147`	`valuesBuilder(Array.isArray(first) ? first : [first], parameters, types, transform, columns)`
`148`	`148`	`}`
`149`		`-}).map(([x, fn]) => ([new RegExp('(^\|[\\s(])' + x, 'i'), fn]))`
	`149`	`+}).map(([x, fn]) => ([new RegExp('(^\|[\\s(])' + x + '($\|[\\s(])', 'i'), fn]))`
`150`	`150`
`151`	`151`	`function notTagged() {`
`152`	`152`	`throw Errors.generic('NOT_TAGGED_CALL', 'Query not called as a tagged template literal')`