Undefined values throws

porsager · porsager · commit 758b5ee7f5fa · 2020-03-10T12:21:22.000+01:00
diff --git a/README.md b/README.md
@@ -519,6 +519,11 @@ Query errors will also contain the `query` string and the `parameters` which are
 
 There are also the following errors specifically for this library.
 
+##### UNDEFINED_VALUE
+> Undefined values are not allowed
+
+Postgres.js won't accept `undefined` as values in tagged template queries since it becomes ambigious what to do with the value. If you want to set something to null, use `null` explicitly.
+
 ##### MESSAGE_NOT_SUPPORTED
 > X (X) is not supported
 
diff --git a/lib/index.js b/lib/index.js
@@ -366,11 +366,9 @@ function Postgres(a, b) {
 
   function parseRaw(query, str, args = []) {
     const types = []
-        , xargs = args.map(x => {
-          const type = getType(x)
-          types.push(type.type)
-          return type
-        })
+        , xargs = []
+
+    args.forEach(x => parseValue(x, xargs, types))
 
     return {
       sig: !query.dynamic && types + str,
@@ -446,6 +444,9 @@ function Postgres(a, b) {
   }
 
   function parseValue(x, xargs, types) {
+    if (x === undefined)
+      throw errors.generic({ code: 'UNDEFINED_VALUE', message: 'Undefined values are not allowed' })
+
     return Array.isArray(x)
       ? x.reduce((acc, x) => acc + (acc ? ',' : '') + addValue(x, xargs, types), '')
       : addValue(x, xargs, types)
diff --git a/tests/index.js b/tests/index.js
@@ -82,10 +82,6 @@ t('null', async() =>
   [null, (await sql`select ${ null } as x`)[0].x]
 )
 
-t('undefined to null', async() =>
-  [null, (await sql`select ${ undefined } as x`)[0].x]
-)
-
 t('Integer', async() =>
   ['1', (await sql`select ${ 1 } as x`)[0].x]
 )
@@ -256,6 +252,20 @@ t('Helpers in Transaction', async() => {
   ))[0].x]
 })
 
+t('Undefined values throws', async() => {
+  let error
+
+  await sql`
+    select ${ undefined } as x
+  `.catch(x => error = x.code)
+
+  return ['UNDEFINED_VALUE', error]
+})
+
+t('Null sets to null', async() =>
+  [null, (await sql`select ${ null } as x`)[0].x]
+)
+
 t('Throw syntax error', async() =>
   ['42601', (await sql`wat 1`.catch(x => x)).code]
 )
