Only cache prepared statement on successful parse

porsager · porsager · commit 9ccf88c04991 · 2019-11-27T12:13:46.000+01:00
diff --git a/lib/backend.js b/lib/backend.js
@@ -6,6 +6,7 @@ const char = (acc, [k, v]) => (acc[k.charCodeAt(0)] = v, acc)
 export default Backend
 
 function Backend({
+  onparse,
   onparameter,
   parsers,
   onauth,
@@ -53,7 +54,9 @@ function Backend({
 
   return backend
 
-  function ParseComplete() { /* No handling needed */ }
+  function ParseComplete() {
+    onparse()
+  }
   function BindComplete() { /* No handling needed */ }
   function CloseComplete() { /* No handling needed */ }
 
diff --git a/lib/connection.js b/lib/connection.js
@@ -34,6 +34,7 @@ export default function Connection(options = {}) {
   })
 
   const backend = Backend({
+    onparse,
     onparameter,
     transform,
     parsers,
@@ -47,6 +48,11 @@ export default function Connection(options = {}) {
 
   return connection
 
+  function onparse() {
+    if (backend.query && backend.query.statement.name)
+      statements[backend.query.statement.sig] = backend.query.statement.name
+  }
+
   function onauth(type, x) {
     socket.write(frontend.auth(type, x, options))
   }
@@ -109,8 +115,7 @@ export default function Connection(options = {}) {
   }
 
   function prepare(sig, str, args, query) {
-    query.statement = { name: sig ? 'p' + id++ : '' }
-    sig && statements.set(sig, query.statement)
+    query.statement = { name: sig ? 'p' + id++ : '', sig }
     return Buffer.concat([
       frontend.Parse(query.statement.name, str, args),
       frontend.Bind(query.statement.name, args)
