Call socket.write with correct arguments - fixes porsager#216

porsager · porsager · commit f40642682853 · 2021-08-27T21:51:56.000+02:00
diff --git a/lib/connection.js b/lib/connection.js
@@ -240,7 +240,7 @@ function Connection(options = {}) {
       if (multi())
         return
 
-      messages.forEach(socket.write)
+      messages.forEach(x => socket.write(x))
       messages = []
       open = true
     }
diff --git a/tests/index.js b/tests/index.js
@@ -1467,3 +1467,18 @@ t('Recreate prepared statements on RevalidateCachedQuery error', async() => {
     await sql`drop table test`
   ]
 })
+
+t('multiple queries before connect', async() => {
+  const sql = postgres({ ...options, max: 2 })
+  const xs = await Promise.all([
+    sql`select 1 as x`,
+    sql`select 2 as x`,
+    sql`select 3 as x`,
+    sql`select 4 as x`
+  ])
+
+  return [
+    '1,2,3,4',
+    xs.map(x => x[0].x).join()
+  ]
+})

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ function Connection(options = {}) {`
`240`	`240`	`if (multi())`
`241`	`241`	`return`
`242`	`242`
`243`		`- messages.forEach(socket.write)`
	`243`	`+ messages.forEach(x => socket.write(x))`
`244`	`244`	`messages = []`
`245`	`245`	`open = true`
`246`	`246`	`}`