mark possibly problematic spots with FIXME

korny · korny · commit 5c23a731ca55 · 2013-07-20T18:12:04.000+02:00
diff --git a/lib/coderay/encoders/html.rb b/lib/coderay/encoders/html.rb
@@ -142,6 +142,7 @@ def self.make_html_escape_hash
     HTML_ESCAPE = make_html_escape_hash
     HTML_ESCAPE_PATTERN = /[\t"&><\0-\x8\xB-\x1F]/
     
+    # FIXME: cache attack
     TOKEN_KIND_TO_INFO = Hash.new do |h, kind|
       h[kind] = kind.to_s.gsub(/_/, ' ').gsub(/\b\w/) { $&.capitalize }
     end
@@ -284,6 +285,7 @@ def style_for_kinds kinds
     end
     
     def make_span_for_kinds method, hint
+      # FIXME: cache attack
       Hash.new do |h, kinds|
         h[kinds.is_a?(Symbol) ? kinds : kinds.dup] = begin
           css_class = css_class_for_kinds(kinds)
diff --git a/lib/coderay/encoders/html/css.rb b/lib/coderay/encoders/html/css.rb
@@ -21,6 +21,7 @@ def initialize style = :default
       end
 
       def get_style_for_css_classes css_classes
+        # FIXME: cache attack
         cl = @styles[css_classes.first]
         return '' unless cl
         style = ''
@@ -52,6 +53,7 @@ def parse stylesheet
           for selector in selectors.split(',')
             classes = selector.scan(/[-\w]+/)
             cl = classes.pop
+            # FIXME: cache attack
             @styles[cl] ||= Hash.new
             @styles[cl][classes] = style.to_s.strip.delete(' ').chomp(';')
           end
diff --git a/lib/coderay/helpers/file_type.rb b/lib/coderay/helpers/file_type.rb
@@ -68,6 +68,7 @@ def shebang filename
         File.open filename, 'r' do |f|
           if first_line = f.gets
             if type = first_line[TypeFromShebang]
+              # FIXME: cache attack
               type.to_sym
             end
           end
diff --git a/lib/coderay/helpers/plugin.rb b/lib/coderay/helpers/plugin.rb
@@ -207,6 +207,7 @@ def validate_id id
         id
       elsif id.is_a? String
         if id[/\w+/] == id
+          # FIXME: cache attack
           id.downcase.to_sym
         else
           raise ArgumentError, "Invalid id given: #{id}"
diff --git a/lib/coderay/scanners/debug.rb b/lib/coderay/scanners/debug.rb
@@ -21,6 +21,7 @@ def scan_tokens encoder, options
           encoder.text_token match, :space
           
         elsif match = scan(/ (\w+) \( ( [^\)\\]* ( \\. [^\)\\]* )* ) \)? /x)
+          # FIXME: cache attack
           kind = self[1].to_sym
           match = self[2].gsub(/\\(.)/m, '\1')
           unless TokenKinds.has_key? kind
@@ -30,6 +31,7 @@ def scan_tokens encoder, options
           encoder.text_token match, kind
           
         elsif match = scan(/ (\w+) ([<\[]) /x)
+          # FIXME: cache attack
           kind = self[1].to_sym
           opened_tokens << kind
           case self[2]
diff --git a/lib/coderay/scanners/diff.rb b/lib/coderay/scanners/diff.rb
@@ -21,6 +21,7 @@ def scan_tokens encoder, options
       line_kind = nil
       state = :initial
       deleted_lines_count = 0
+      # FIXME: cache attack
       scanners = Hash.new do |h, lang|
         h[lang] = Scanners[lang].new '', :keep_tokens => true, :keep_state => true
       end
diff --git a/lib/coderay/scanners/python.rb b/lib/coderay/scanners/python.rb
@@ -75,10 +75,12 @@ class Python < Scanner
       <<=? | >>=? | [<>=]=? | !=  # comparison and assignment
     /x  # :nodoc:
     
+    # FIXME: cache attack
     STRING_DELIMITER_REGEXP = Hash.new { |h, delimiter|
       h[delimiter] = Regexp.union delimiter  # :nodoc:
     }
     
+    # FIXME: cache attack
     STRING_CONTENT_REGEXP = Hash.new { |h, delimiter|
       h[delimiter] = / [^\\\n]+? (?= \\ | $ | #{Regexp.escape(delimiter)} ) /x  # :nodoc:
     }
@@ -183,6 +185,7 @@ def scan_tokens encoder, options
               kind = :ident
             elsif kind == :keyword
               state = DEF_NEW_STATE[match]
+              # FIXME: cache attack
               from_import_state << match.to_sym if state == :include_expected
             end
             encoder.text_token match, kind
diff --git a/lib/coderay/scanners/raydebug.rb b/lib/coderay/scanners/raydebug.rb
@@ -26,6 +26,7 @@ def scan_tokens encoder, options
           encoder.text_token kind, :class
           encoder.text_token '(', :operator
           match = self[2]
+          # FIXME: cache attack
           encoder.text_token match, kind.to_sym unless match.empty?
           encoder.text_token match, :operator if match = scan(/\)/)
           
@@ -39,6 +40,7 @@ def scan_tokens encoder, options
           else
             raise 'CodeRay bug: This case should not be reached.'
           end
+          # FIXME: cache attack
           kind = kind.to_sym
           opened_tokens << kind
           encoder.begin_group kind
diff --git a/lib/coderay/scanners/ruby/string_state.rb b/lib/coderay/scanners/ruby/string_state.rb
@@ -14,6 +14,7 @@ class StringState < Struct.new :type, :interpreted, :delim, :heredoc,
         { }
       ] ].each { |k,v| k.freeze; v.freeze }  # debug, if I try to change it with <<
       
+      # FIXME: cache attack
       STRING_PATTERN = Hash.new do |h, k|
         delim, interpreted = *k
         # delim = delim.dup  # workaround for old Ruby
