feat: add pagination to practice problems api

eisbilir · eisbilir · commit 97e600724cc2 · 2023-11-24T16:21:35.000+03:00
diff --git a/src/common/srm-helper.js b/src/common/srm-helper.js
@@ -163,7 +163,9 @@ function getPracticeProblemsQuery(criteria) {
     );
   }
 
-  const query = `SELECT
+  const queryCount = `SELECT count(*) AS count`;
+
+  const querySelect = `SELECT
   SKIP ${offset}
   FIRST ${criteria.perPage}
     p.problem_id AS problemId
@@ -182,8 +184,9 @@ function getPracticeProblemsQuery(criteria) {
          WHEN pcs.status_id = 150 THEN 'Solved'::nvarchar(50)
          WHEN pcs.status_id >= 120 AND pcs.status_id != 150 THEN 'Viewed'::nvarchar(50)
       END AS status
-  , NVL(pcs.points, 0) AS myPoints
-  FROM informixoltp:problem p
+  , NVL(pcs.points, 0) AS myPoints`;
+
+  const queryFrom = `FROM informixoltp:problem p
   INNER JOIN informixoltp:problem_type_lu ptl ON ptl.problem_type_id = p.problem_type_id
   INNER JOIN informixoltp:component c ON c.problem_id = p.problem_id
   INNER JOIN informixoltp:round_component rc ON rc.component_id = c.component_id
@@ -193,9 +196,11 @@ function getPracticeProblemsQuery(criteria) {
     criteria.userId
   }
   WHERE ${_.join(filters, " AND ")}
-  ORDER BY ${sortBy} ${criteria.sortOrder}
-  `;
-  return query;
+  ORDER BY ${sortBy} ${criteria.sortOrder}`;
+
+  const query = `${querySelect} ${queryFrom}`;
+  const countQuery = `${queryCount} ${queryFrom}`;
+  return { query, countQuery };
 }
 
 function convertSRMScheduleQueryOutput(queryOutput) {
diff --git a/src/controllers/ChallengeController.js b/src/controllers/ChallengeController.js
@@ -143,7 +143,8 @@ async function getSRMSchedule(req, res) {
  */
 async function getPracticeProblems(req, res) {
   const result = await service.getPracticeProblems(req, req.authUser, req.query);
-  res.send(result);
+  helper.setResHeaders(req, res, result);
+  res.send(result.result);
 }
 
 module.exports = {
diff --git a/src/services/ChallengeService.js b/src/services/ChallengeService.js
@@ -2491,9 +2491,12 @@ getSRMSchedule.schema = {
  */
 async function getPracticeProblems(currentUser, criteria = {}) {
   criteria.userId = currentUser.userId;
-  const sql = getPracticeProblemsQuery(criteria);
-  const result = await aclQueryDomain.rawQuery({ sql });
-  return convertPracticeProblemsQueryOutput(result);
+  const { query, countQuery } = getPracticeProblemsQuery(criteria);
+  const resultOutput = await aclQueryDomain.rawQuery({ sql: query });
+  const countOutput = await aclQueryDomain.rawQuery({ sql: countQuery });
+  const result = convertPracticeProblemsQueryOutput(resultQueryOutput);
+  const total = countOutput.rows[0].fields[0].value;
+  return { total, page: criteria.page, perPage: criteria.perPage, result };
 }
 
 getPracticeProblems.schema = {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,8 @@ async function getSRMSchedule(req, res) {`
`143`	`143`	`*/`
`144`	`144`	`async function getPracticeProblems(req, res) {`
`145`	`145`	`const result = await service.getPracticeProblems(req, req.authUser, req.query);`
`146`		`- res.send(result);`
	`146`	`+ helper.setResHeaders(req, res, result);`
	`147`	`+ res.send(result.result);`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`module.exports = {`