Merge pull request #1 from bountyC0d3r/plat-1985-implement-caching

bountyC0d3r · web-flow · commit 9d57d74a8514 · 2023-01-09T07:42:10.000+01:00
updated the flag name and corrected the validation
diff --git a/src/services/GroupService.js b/src/services/GroupService.js
@@ -315,8 +315,8 @@ async function getGroup(currentUser, groupId, criteria) {
     )}`
   )
 
-  if (!_.has(criteria, 'isCache')) {
-    criteria.isCache = true
+  if (_.has(criteria, 'skipCache')) {
+    criteria.skipCache = false
   }
 
   if (criteria.includeSubGroups && criteria.includeParentGroup) {
@@ -372,12 +372,12 @@ async function getGroup(currentUser, groupId, criteria) {
   let groupToReturn
 
   try {
-    if (criteria.isCache) {
+    if (!criteria.skipCache) {
       // check for the availibility of the group in cache
       groupToReturn = cache.get(groupId)
     }
 
-    if (criteria.isCache && groupToReturn) {
+    if (!criteria.skipCache && groupToReturn) {
       if (!isAdmin) delete groupToReturn.status
 
       // if the group is private, the user needs to be a member of the group, or an admin
@@ -480,6 +480,7 @@ getGroup.schema = {
     includeSubGroups: Joi.boolean().default(false),
     includeParentGroup: Joi.boolean().default(false),
     flattenGroupIdTree: Joi.boolean().default(false),
+    skipCache: Joi.boolean().default(false),
     oneLevel: Joi.boolean(),
     fields: Joi.string()
   })
