I created this new explode function, which fixes several bugs that I found in the previous version. Note: sorry for any english mistakes, english is not my first language. I also posted this function in http://phpjs.org/functions/explode:396#comment_153595

Ghabriel · Ghabriel · commit 04d0c075ecb9 · 2012-03-19T12:32:25.000-03:00
diff --git a/functions/strings/explode.js b/functions/strings/explode.js
@@ -1,42 +1,33 @@
 function explode (delimiter, string, limit) {
-    // http://kevin.vanzonneveld.net
-    // +     original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
-    // +     improved by: kenneth
-    // +     improved by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
-    // +     improved by: d3x
-    // +     bugfixed by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
-    // *     example 1: explode(' ', 'Kevin van Zonneveld');
-    // *     returns 1: {0: 'Kevin', 1: 'van', 2: 'Zonneveld'}
-    // *     example 2: explode('=', 'a=bc=d', 2);
-    // *     returns 2: ['a', 'bc=d']
-    var emptyArray = {
-        0: ''
-    };
 
-    // third argument is not required
-    if (arguments.length < 2 || typeof arguments[0] == 'undefined' || typeof arguments[1] == 'undefined') {
-        return null;
-    }
+    if ( arguments.length < 2 || typeof delimiter == 'undefined' || typeof string == 'undefined' ) return null;
+	if ( delimiter === '' || delimiter === false || delimiter === null) return false;
+	if ( typeof delimiter == 'function' || typeof delimiter == 'object' || typeof string == 'function' || typeof string == 'object'){
+		return { 0: '' };
+	}
+	if ( delimiter === true ) delimiter = '1';
+	
+	// Here we go...
+	delimiter += '';
+	string += '';
+	
+	var s = string.split( delimiter );
+	
 
-    if (delimiter === '' || delimiter === false || delimiter === null) {
-        return false;
-    }
+	if ( typeof limit === 'undefined' ) return s;
+	
+	// Support for limit
+	if ( limit === 0 ) limit = 1;
+	
+	// Positive limit
+	if ( limit > 0 ){
+		if ( limit >= s.length ) return s;
+		return s.slice( 0, limit - 1 ).concat( [ s.slice( limit - 1 ).join( delimiter ) ] );
+	}
 
-    if (typeof delimiter == 'function' || typeof delimiter == 'object' || typeof string == 'function' || typeof string == 'object') {
-        return emptyArray;
-    }
-
-    if (delimiter === true) {
-        delimiter = '1';
-    }
-
-    if (!limit) {
-        return string.toString().split(delimiter.toString());
-    }
-    // support for limit argument
-    var splitted = string.toString().split(delimiter.toString());
-    var partA = splitted.splice(0, limit - 1);
-    var partB = splitted.join(delimiter.toString());
-    partA.push(partB);
-    return partA;
-}
+	// Negative limit
+	if ( -limit >= s.length ) return [];
+	
+	s.splice( s.length + limit );
+	return s;
+}
