str_shuffle should return empty string for null argument. No need to define getRandomInt function for such small calculation

kukawski · kukawski · commit 4b67bca0cca1 · 2011-12-11T23:21:21.000+01:00
diff --git a/functions/strings/str_shuffle.js b/functions/strings/str_shuffle.js
@@ -3,18 +3,16 @@ function str_shuffle (str) {
     // +   original by: Brett Zamir (http://brett-zamir.me)
     // *     example 1: shuffled = str_shuffle("abcdef");
     // *     results 1: shuffled.length == 6
-    if (str == undefined) {
+    if (str == null) {
         throw 'Wrong parameter count for str_shuffle()';
     }
+    
+    str += '';
 
-    var getRandomInt = function (max) {
-        return Math.floor(Math.random() * (max + 1));
-    };
-    var newStr = '',
-        rand = 0;
+    var newStr = '', rand;
 
     while (str.length) {
-        rand = getRandomInt(str.length - 1);
+        rand = Math.floor(Math.random() * str.length);
         newStr += str.charAt(rand);
         str = str.substring(0, rand) + str.substr(rand + 1);
     }
