Bugfixed with similar_text (thanks Chris McMacken!); minor coding standard changes

brettz9 · brettz9 · commit 4e944f4b9001 · 2011-01-31T18:09:00.000+08:00
diff --git a/functions/strings/similar_text.js b/functions/strings/similar_text.js
@@ -1,12 +1,13 @@
 function similar_text (first, second) {
     // http://kevin.vanzonneveld.net
     // +   original by: Rafał Kukawski (http://blog.kukawski.pl)
+    // +   bugfixed by: Chris McMacken
     // *     example 1: similar_text('Hello World!', 'Hello phpjs!');
     // *     returns 1: 7
     // *     example 2: similar_text('Hello World!', null);
     // *     returns 2: 0
     
-    if (first === null || second === null || typeof first === "undefined" || typeof second === "undefined") {
+    if (first === null || second === null || typeof first === 'undefined' || typeof second === 'undefined') {
         return 0;
     }
     
@@ -33,14 +34,13 @@ function similar_text (first, second) {
     
     if (sum) {
         if (pos1 && pos2) {
-            sum += similar_text(first.substr(0, pos2), second.substr(0, pos2));
+            sum += this.similar_text(first.substr(0, pos2), second.substr(0, pos2));
         }
         
         if ((pos1 + max < firstLength) && (pos2 + max < secondLength)) {
-            sum += similar_text(first.substr(pos1 + max, firstLength - pos1 - max), second.substr(pos2 + max, secondLength - pos2 - max));
+            sum += this.similar_text(first.substr(pos1 + max, firstLength - pos1 - max), second.substr(pos2 + max, secondLength - pos2 - max));
         }
     }
     
     return sum;
 }
-

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,13 @@`
`1`	`1`	`function similar_text (first, second) {`
`2`	`2`	`// http://kevin.vanzonneveld.net`
`3`	`3`	`// + original by: Rafał Kukawski (http://blog.kukawski.pl)`
	`4`	`+ // + bugfixed by: Chris McMacken`
`4`	`5`	`// * example 1: similar_text('Hello World!', 'Hello phpjs!');`
`5`	`6`	`// * returns 1: 7`
`6`	`7`	`// * example 2: similar_text('Hello World!', null);`
`7`	`8`	`// * returns 2: 0`
`8`	`9`
`9`		`- if (first === null \|\| second === null \|\| typeof first === "undefined" \|\| typeof second === "undefined") {`
	`10`	`+ if (first === null \|\| second === null \|\| typeof first === 'undefined' \|\| typeof second === 'undefined') {`
`10`	`11`	`return 0;`
`11`	`12`	`}`
`12`	`13`
`@@ -33,14 +34,13 @@ function similar_text (first, second) {`
`33`	`34`
`34`	`35`	`if (sum) {`
`35`	`36`	`if (pos1 && pos2) {`
`36`		`- sum += similar_text(first.substr(0, pos2), second.substr(0, pos2));`
	`37`	`+ sum += this.similar_text(first.substr(0, pos2), second.substr(0, pos2));`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`if ((pos1 + max < firstLength) && (pos2 + max < secondLength)) {`
`40`		`- sum += similar_text(first.substr(pos1 + max, firstLength - pos1 - max), second.substr(pos2 + max, secondLength - pos2 - max));`
	`41`	`+ sum += this.similar_text(first.substr(pos1 + max, firstLength - pos1 - max), second.substr(pos2 + max, secondLength - pos2 - max));`
`41`	`42`	`}`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`return sum;`
`45`	`46`	`}`
`46`		`-`