Remove dead code on ord (thanks incidence!); simplify ord/chr

brettz9 · brettz9 · commit cd5bd1c2ce01 · 2011-01-24T11:43:56.000+08:00
diff --git a/functions/strings/chr.js b/functions/strings/chr.js
@@ -14,7 +14,5 @@ function chr (codePt) {
         codePt -= 0x10000;
         return String.fromCharCode(0xD800 + (codePt >> 10), 0xDC00 + (codePt & 0x3FF));
     }
-    else {
-        return String.fromCharCode(codePt);
-    }
+    return String.fromCharCode(codePt);
 }
diff --git a/functions/strings/ord.js b/functions/strings/ord.js
@@ -3,23 +3,19 @@ function ord (string) {
     // +   original by: Kevin van Zonneveld (http://kevin.vanzonneveld.net)
     // +   bugfixed by: Onno Marsman
     // +   improved by: Brett Zamir (http://brett-zamir.me)
+    // +   input by: incidence
     // *     example 1: ord('K');
     // *     returns 1: 75
     // *     example 2: ord('\uD800\uDC00'); // surrogate pair to create a single Unicode character
     // *     returns 2: 65536
 
-    var str = string + '';
-    
-    var code = str.charCodeAt(0);
+    var str = string + '',
+        code = str.charCodeAt(0);
     if (0xD800 <= code && code <= 0xDBFF) { // High surrogate (could change last hex to 0xDB7F to treat high private surrogates as single characters)
         var hi = code;
         if (str.length === 1) {
             return code; // This is just a high surrogate with no following low surrogate, so we return its value;
                                     // we could also throw an error as it is not a complete character, but someone may want to know
-        }
-        var low = str.charCodeAt(1);
-        if (!low) {
-            
         }
         return ((hi - 0xD800) * 0x400) + (low - 0xDC00) + 0x10000;
     }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,5 @@ function chr (codePt) {`
`14`	`14`	`codePt -= 0x10000;`
`15`	`15`	`return String.fromCharCode(0xD800 + (codePt >> 10), 0xDC00 + (codePt & 0x3FF));`
`16`	`16`	`}`
`17`		`- else {`
`18`		`- return String.fromCharCode(codePt);`
`19`		`- }`
	`17`	`+ return String.fromCharCode(codePt);`
`20`	`18`	`}`