Skip to content

Add doubly linked list #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huzaima opened this issue Jul 2, 2018 · 5 comments
Closed

Add doubly linked list #87

huzaima opened this issue Jul 2, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@huzaima
Copy link
Contributor

huzaima commented Jul 2, 2018

Shouldn't there be doubly linked list too?

If yes, can I contribute for it?
@trekhleb trekhleb added the enhancement New feature or request label Jul 4, 2018
@trekhleb
Copy link
Owner

trekhleb commented Jul 4, 2018 •
edited
Loading

Hello @huzaima
Yes, we may have a separate class for DoublyLinkedList. This class at least must contain all public methods of LinkedList like prepend(), append() and so on, just to have uniform way of using both of them. Thank you for suggestion!

@huzaima
Copy link
Contributor Author

huzaima commented Jul 4, 2018

@trekhleb I'm starting work on this.

@andela-anandaa
Copy link

@huzaima - let me know how it goes, would love to help out.

@huzaima
Copy link
Contributor Author

huzaima commented Jul 4, 2018

Hey @andela-anandaa, check the PR I submitted for this. Kindly let me know if anything can be improved.

@trekhleb
Copy link
Owner

trekhleb commented Jul 5, 2018

Thank you for the fix @huzaima

@trekhleb trekhleb closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trekhleb @andela-anandaa @huzaima