Revert "fix: fix HMR issue on Android (nativescript-vue#461)" as it does not work with {N}-5.2 but works with {N}-5.3

msaelices · msaelices · commit 621e7e6318a3 · 2019-04-05T15:40:46.000+02:00
This reverts commit 595d2a0.
diff --git a/platform/nativescript/runtime/components/frame.js b/platform/nativescript/runtime/components/frame.js
@@ -157,12 +157,32 @@ export default {
 
         // replace the controllers instead of pushing directly
         frame._ios.controller.setViewControllersAnimated(newControllers, false)
+      } else {
+        const frameId = frame._android.frameId
+        frame._isBack = false
+        backstackEntry.frameId = frameId
+
+        const manager = frame._getFragmentManager()
+        const currentEntry = frame._currentEntry
+
+        const newFragmentTag = `fragment${frameId}[-1]`
+        const newFragment = frame.createFragment(backstackEntry, newFragmentTag)
+        const animated = false
+        const navigationTransition = null
+
+        const transaction = manager.beginTransaction()
+        _setAndroidFragmentTransitions(
+          animated,
+          navigationTransition,
+          currentEntry,
+          backstackEntry,
+          transaction,
+          frameId
+        )
+        transaction.remove(currentEntry.fragment)
+        transaction.replace(frame.containerViewId, newFragment, newFragmentTag)
+        transaction.commitAllowingStateLoss()
       }
-      // Note: in the Android platform there is nothing to do, as the
-      // page is able to change without the need of replacing the last
-      // navigation entry
-
-      // reset HMR checking flag
       resetHMRChecking()
     },
 
diff --git a/platform/nativescript/runtime/components/list-view.js b/platform/nativescript/runtime/components/list-view.js
@@ -51,7 +51,7 @@ export default {
 
   mounted() {
     if (!this.$templates) {
-      return
+        return;
     }
 
     this.$refs.listView.setAttribute(
@@ -69,9 +69,9 @@ export default {
     },
     onItemLoading(args) {
       if (!this.$templates) {
-        return
+        return;
       }
-
+ 
       const index = args.index
       const items = args.object.items
 
