Add support for <ol reversed>, related attributes

twm · twm · commit 40bd63e6f588 · 2018-06-09T18:46:46.000-07:00
* Mark <ol reversed> as a boolean attribute so it serializes properly in HTML. * Allow <ol reversed> in the sanitizer. Closes html5lib#321. * Allow <ol start> in the sanitizer. * <ol type> was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future. https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,6 +1,16 @@
 Change Log
 ----------
 
+1.1.0
+~~~~~
+
+Features:
+
+* Add support serializing the ``<ol reversed>`` boolean attribute. (Thank you,
+  Tom Most!)
+* The ``<ol reversed>`` and ``<ol start>`` attributes are now permitted by the
+  sanitizer. (#321) (Thank you, Tom Most!)
+
 1.0.1
 ~~~~~
 
diff --git a/html5lib/constants.py b/html5lib/constants.py
@@ -605,6 +605,7 @@
     "button": frozenset(["disabled", "autofocus"]),
     "input": frozenset(["disabled", "readonly", "required", "autofocus", "checked", "ismap"]),
     "select": frozenset(["disabled", "readonly", "autofocus", "multiple"]),
+    "ol": frozenset(["reversed"]),
     "output": frozenset(["disabled", "readonly"]),
     "iframe": frozenset(["seamless"]),
 }
diff --git a/html5lib/filters/sanitizer.py b/html5lib/filters/sanitizer.py
@@ -346,6 +346,7 @@
     (None, 'maxsize'),
     (None, 'minsize'),
     (None, 'other'),
+    (None, 'reversed'),
     (None, 'rowalign'),
     (None, 'rowalign'),
     (None, 'rowalign'),
@@ -356,6 +357,7 @@
     (None, 'scriptlevel'),
     (None, 'selection'),
     (None, 'separator'),
+    (None, 'start'),
     (None, 'stretchy'),
     (None, 'width'),
     (None, 'width'),
diff --git a/html5lib/tests/test_sanitizer.py b/html5lib/tests/test_sanitizer.py
@@ -125,3 +125,21 @@ def test_uppercase_color_codes_in_style():
     sanitized = sanitize_html("<p style=\"border: 1px solid #A2A2A2;\"></p>")
     expected = '<p style=\"border: 1px solid #A2A2A2;\"></p>'
     assert expected == sanitized
+
+
+def test_ol_start_allowed():
+    sanitized = sanitize_html("<ol start=2><li>.</ol>")
+    expected = '<ol start="2"><li>.</li></ol>'
+    assert expected == sanitized
+
+
+def test_ol_type_allowed():
+    sanitized = sanitize_html("<ol type=I><li>.</ol>")
+    expected = '<ol type="I"><li>.</li></ol>'
+    assert expected == sanitized
+
+
+def test_ol_reversed_allowed():
+    sanitized = sanitize_html("<ol reversed><li>.</ol>")
+    expected = '<ol reversed><li>.</li></ol>'
+    assert expected == sanitized

Original file line number	Diff line number	Diff line change
`@@ -605,6 +605,7 @@`
`605`	`605`	`"button": frozenset(["disabled", "autofocus"]),`
`606`	`606`	`"input": frozenset(["disabled", "readonly", "required", "autofocus", "checked", "ismap"]),`
`607`	`607`	`"select": frozenset(["disabled", "readonly", "autofocus", "multiple"]),`
	`608`	`+ "ol": frozenset(["reversed"]),`
`608`	`609`	`"output": frozenset(["disabled", "readonly"]),`
`609`	`610`	`"iframe": frozenset(["seamless"]),`
`610`	`611`	`}`