Modules are always in strict mode in ES6.

CyrusNajmabadi · CyrusNajmabadi · commit dcbfa6988a8d · 2015-06-15T18:01:18.000-07:00
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -88,7 +88,11 @@ namespace ts {
         let container: Node;
         let blockScopeContainer: Node;
         let lastContainer: Node;
-        let inStrictMode = false;
+
+        // If this file is an external module, then it is automatically in strict-mode according to
+        // ES6.  If it is not an external module, then we'll determine if it is in strict mode or 
+        // not depending on if we see "use strict" in certain places.
+        let inStrictMode = !!file.externalModuleIndicator;
 
         let symbolCount = 0;
         let Symbol = objectAllocator.getSymbolConstructor();
diff --git a/tests/baselines/reference/exportNonInitializedVariablesAMD.errors.txt b/tests/baselines/reference/exportNonInitializedVariablesAMD.errors.txt
@@ -1,15 +1,18 @@
 tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts(2,4): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts(3,1): error TS1212: Identifier expected. 'let' is a reserved word in strict mode
 tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts(3,1): error TS2304: Cannot find name 'let'.
 tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts(4,6): error TS1123: Variable declaration list cannot be empty.
 
 
-==== tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts (3 errors) ====
+==== tests/cases/conformance/externalModules/exportNonInitializedVariablesAMD.ts (4 errors) ====
     
     var;
        
 !!! error TS1123: Variable declaration list cannot be empty.
     let;
     ~~~
+!!! error TS1212: Identifier expected. 'let' is a reserved word in strict mode
+    ~~~
 !!! error TS2304: Cannot find name 'let'.
     const;
          
diff --git a/tests/baselines/reference/exportNonInitializedVariablesCommonJS.errors.txt b/tests/baselines/reference/exportNonInitializedVariablesCommonJS.errors.txt
@@ -1,15 +1,18 @@
 tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts(2,4): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts(3,1): error TS1212: Identifier expected. 'let' is a reserved word in strict mode
 tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts(3,1): error TS2304: Cannot find name 'let'.
 tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts(4,6): error TS1123: Variable declaration list cannot be empty.
 
 
-==== tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts (3 errors) ====
+==== tests/cases/conformance/externalModules/exportNonInitializedVariablesCommonJS.ts (4 errors) ====
     
     var;
        
 !!! error TS1123: Variable declaration list cannot be empty.
     let;
     ~~~
+!!! error TS1212: Identifier expected. 'let' is a reserved word in strict mode
+    ~~~
 !!! error TS2304: Cannot find name 'let'.
     const;
          
diff --git a/tests/baselines/reference/exportNonInitializedVariablesES6.errors.txt b/tests/baselines/reference/exportNonInitializedVariablesES6.errors.txt
@@ -1,15 +1,18 @@
 tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts(2,4): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts(3,1): error TS1212: Identifier expected. 'let' is a reserved word in strict mode
 tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts(3,1): error TS2304: Cannot find name 'let'.
 tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts(4,6): error TS1123: Variable declaration list cannot be empty.
 
 
-==== tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts (3 errors) ====
+==== tests/cases/conformance/externalModules/exportNonInitializedVariablesES6.ts (4 errors) ====
     
     var;
        
 !!! error TS1123: Variable declaration list cannot be empty.
     let;
     ~~~
+!!! error TS1212: Identifier expected. 'let' is a reserved word in strict mode
+    ~~~
 !!! error TS2304: Cannot find name 'let'.
     const;
          
diff --git a/tests/baselines/reference/exportNonInitializedVariablesSystem.errors.txt b/tests/baselines/reference/exportNonInitializedVariablesSystem.errors.txt
@@ -1,15 +1,18 @@
 tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts(2,4): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts(3,1): error TS1212: Identifier expected. 'let' is a reserved word in strict mode
 tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts(3,1): error TS2304: Cannot find name 'let'.
 tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts(4,6): error TS1123: Variable declaration list cannot be empty.
 
 
-==== tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts (3 errors) ====
+==== tests/cases/conformance/externalModules/exportNonInitializedVariablesSystem.ts (4 errors) ====
     
     var;
        
 !!! error TS1123: Variable declaration list cannot be empty.
     let;
     ~~~
+!!! error TS1212: Identifier expected. 'let' is a reserved word in strict mode
+    ~~~
 !!! error TS2304: Cannot find name 'let'.
     const;
          
diff --git a/tests/baselines/reference/exportNonInitializedVariablesUMD.errors.txt b/tests/baselines/reference/exportNonInitializedVariablesUMD.errors.txt
@@ -1,15 +1,18 @@
 tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts(2,4): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts(3,1): error TS1212: Identifier expected. 'let' is a reserved word in strict mode
 tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts(3,1): error TS2304: Cannot find name 'let'.
 tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts(4,6): error TS1123: Variable declaration list cannot be empty.
 
 
-==== tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts (3 errors) ====
+==== tests/cases/conformance/externalModules/exportNonInitializedVariablesUMD.ts (4 errors) ====
     
     var;
        
 !!! error TS1123: Variable declaration list cannot be empty.
     let;
     ~~~
+!!! error TS1212: Identifier expected. 'let' is a reserved word in strict mode
+    ~~~
 !!! error TS2304: Cannot find name 'let'.
     const;
          
diff --git a/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.errors.txt b/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.errors.txt
@@ -0,0 +1,23 @@
+tests/cases/conformance/es6/modules/t3.ts(1,17): error TS1212: Identifier expected. 'yield' is a reserved word in strict mode
+
+
+==== tests/cases/conformance/es6/modules/t1.ts (0 errors) ====
+    
+    let set = {
+        set foo(x: number) {
+        }
+    }
+    let get = 10;
+    
+    export { set, get };
+    
+==== tests/cases/conformance/es6/modules/t2.ts (0 errors) ====
+    import * as set from "./t1";
+    
+==== tests/cases/conformance/es6/modules/t3.ts (1 errors) ====
+    import { set as yield } from "./t1";
+                    ~~~~~
+!!! error TS1212: Identifier expected. 'yield' is a reserved word in strict mode
+    
+==== tests/cases/conformance/es6/modules/t4.ts (0 errors) ====
+    import { get } from "./t1";
diff --git a/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.symbols b/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.symbols
diff --git a/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.types b/tests/baselines/reference/exportsAndImportsWithContextualKeywordNames01.types
