Skip to content

Commit 38dab74

Browse files
authored
Fix lint race when not running tests in parallel (microsoft#25235)
1 parent 133bb9f commit 38dab74

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

Jakefile.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,6 @@ function runConsoleTests(defaultReporter, runInParallel) {
486486
process.env.NODE_ENV = savedNodeEnv;
487487
Travis.measure(startTime);
488488
runLinterAndComplete();
489-
finish();
490489
}, function (e, status) {
491490
process.env.NODE_ENV = savedNodeEnv;
492491
Travis.measure(startTime);
@@ -523,11 +522,11 @@ function runConsoleTests(defaultReporter, runInParallel) {
523522

524523
function runLinterAndComplete() {
525524
if (!lintFlag || dirty) {
526-
return;
525+
return finish();
527526
}
528527
var lint = jake.Task['lint'];
529-
lint.addListener('complete', function () {
530-
complete();
528+
lint.once('complete', function () {
529+
finish();
531530
});
532531
lint.invoke();
533532
}

0 commit comments

Comments
 (0)