Merge pull request microsoft#22450 from Microsoft/reenableTest

sheetalkamat · web-flow · commit 3f2ff0125aff · 2018-03-12T14:47:02.000-07:00
Enable the commented out test and convert folder entries to sorted list
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -24,14 +24,14 @@ namespace ts {
      * Make `elements` into a `NodeArray<T>`. If `elements` is `undefined`, returns an empty `NodeArray<T>`.
      */
     export function createNodeArray<T extends Node>(elements?: ReadonlyArray<T>, hasTrailingComma?: boolean): NodeArray<T> {
-        if (elements) {
+        if (!elements || elements === emptyArray) {
+            elements = [];
+        }
+        else {
             if (isNodeArray(elements)) {
                 return elements;
             }
         }
-        else {
-            elements = [];
-        }
 
         const array = <NodeArray<T>>elements;
         array.pos = -1;
diff --git a/src/harness/unittests/tscWatchMode.ts b/src/harness/unittests/tscWatchMode.ts
@@ -2333,9 +2333,9 @@ declare module "fs" {
                 verifyRenamingFileInSubFolder(TestFSWithWatch.Tsc_WatchDirectory.NonRecursiveWatchDirectory);
             });
 
-            // it("uses non recursive dynamic polling when renaming file in subfolder", () => {
-            //     verifyRenamingFileInSubFolder(TestFSWithWatch.Tsc_WatchDirectory.DynamicPolling);
-            // });
+            it("uses non recursive dynamic polling when renaming file in subfolder", () => {
+                verifyRenamingFileInSubFolder(TestFSWithWatch.Tsc_WatchDirectory.DynamicPolling);
+            });
         });
     });
 }
diff --git a/src/harness/virtualFileSystemWithWatch.ts b/src/harness/virtualFileSystemWithWatch.ts
@@ -88,7 +88,7 @@ interface Array<T> {}`
     }
 
     interface Folder extends FSEntry {
-        entries: FSEntry[];
+        entries: SortedArray<FSEntry>;
     }
 
     interface SymLink extends FSEntry {
@@ -504,7 +504,7 @@ interface Array<T> {}`
         }
 
         private addFileOrFolderInFolder(folder: Folder, fileOrDirectory: File | Folder | SymLink, ignoreWatch?: boolean) {
-            folder.entries.push(fileOrDirectory);
+            insertSorted(folder.entries, fileOrDirectory, (a, b) => compareStringsCaseSensitive(getBaseFileName(a.path), getBaseFileName(b.path)));
             folder.modifiedTime = new Date();
             this.fs.set(fileOrDirectory.path, fileOrDirectory);
 
@@ -606,7 +606,7 @@ interface Array<T> {}`
 
         private toFolder(path: string): Folder {
             const folder = this.toFsEntry(path) as Folder;
-            folder.entries = [];
+            folder.entries = [] as SortedArray<FSEntry>;
             return folder;
         }
 

Original file line number	Diff line number	Diff line change
@@ -88,7 +88,7 @@ interface Array<T> {}`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`interface Folder extends FSEntry {`
`91`		`- entries: FSEntry[];`
	`91`	`+ entries: SortedArray<FSEntry>;`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`interface SymLink extends FSEntry {`
@@ -504,7 +504,7 @@ interface Array<T> {}`
`504`	`504`	`}`
`505`	`505`
`506`	`506`	`private addFileOrFolderInFolder(folder: Folder, fileOrDirectory: File \| Folder \| SymLink, ignoreWatch?: boolean) {`
`507`		`- folder.entries.push(fileOrDirectory);`
	`507`	`+ insertSorted(folder.entries, fileOrDirectory, (a, b) => compareStringsCaseSensitive(getBaseFileName(a.path), getBaseFileName(b.path)));`
`508`	`508`	`folder.modifiedTime = new Date();`
`509`	`509`	`this.fs.set(fileOrDirectory.path, fileOrDirectory);`
`510`	`510`
@@ -606,7 +606,7 @@ interface Array<T> {}`
`606`	`606`
`607`	`607`	`private toFolder(path: string): Folder {`
`608`	`608`	`const folder = this.toFsEntry(path) as Folder;`
`609`		`- folder.entries = [];`
	`609`	`+ folder.entries = [] as SortedArray<FSEntry>;`
`610`	`610`	`return folder;`
`611`	`611`	`}`
`612`	`612`