Merge pull request microsoft#20671 from Kingwl/fix-import-not-existed-module

mhegazy · web-flow · commit 52192006cf22 · 2018-04-17T17:29:07.000-07:00
error if import empty object form module not existed
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -24465,7 +24465,10 @@ namespace ts {
                             checkImportBinding(importClause.namedBindings);
                         }
                         else {
-                            forEach(importClause.namedBindings.elements, checkImportBinding);
+                            const moduleExisted = resolveExternalModuleName(node, node.moduleSpecifier);
+                            if (moduleExisted) {
+                                forEach(importClause.namedBindings.elements, checkImportBinding);
+                            }
                         }
                     }
                 }
diff --git a/tests/baselines/reference/importEmptyFromModuleNotExisted.errors.txt b/tests/baselines/reference/importEmptyFromModuleNotExisted.errors.txt
@@ -0,0 +1,8 @@
+tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts(1,16): error TS2307: Cannot find module 'module-not-existed'.
+
+
+==== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts (1 errors) ====
+    import {} from 'module-not-existed'
+                   ~~~~~~~~~~~~~~~~~~~~
+!!! error TS2307: Cannot find module 'module-not-existed'.
+    
diff --git a/tests/baselines/reference/importEmptyFromModuleNotExisted.js b/tests/baselines/reference/importEmptyFromModuleNotExisted.js
@@ -0,0 +1,7 @@
+//// [importEmptyFromModuleNotExisted.ts]
+import {} from 'module-not-existed'
+
+
+//// [importEmptyFromModuleNotExisted.js]
+"use strict";
+exports.__esModule = true;
diff --git a/tests/baselines/reference/importEmptyFromModuleNotExisted.symbols b/tests/baselines/reference/importEmptyFromModuleNotExisted.symbols
@@ -0,0 +1,4 @@
+=== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts ===
+import {} from 'module-not-existed'
+No type information for this code.
+No type information for this code.
diff --git a/tests/baselines/reference/importEmptyFromModuleNotExisted.types b/tests/baselines/reference/importEmptyFromModuleNotExisted.types
@@ -0,0 +1,4 @@
+=== tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts ===
+import {} from 'module-not-existed'
+No type information for this code.
+No type information for this code.
diff --git a/tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts b/tests/cases/conformance/es6/modules/importEmptyFromModuleNotExisted.ts
@@ -0,0 +1 @@
+import {} from 'module-not-existed'

Original file line number	Diff line number	Diff line change
`@@ -24465,7 +24465,10 @@ namespace ts {`
`24465`	`24465`	`checkImportBinding(importClause.namedBindings);`
`24466`	`24466`	`}`
`24467`	`24467`	`else {`
`24468`		`- forEach(importClause.namedBindings.elements, checkImportBinding);`
	`24468`	`+ const moduleExisted = resolveExternalModuleName(node, node.moduleSpecifier);`
	`24469`	`+ if (moduleExisted) {`
	`24470`	`+ forEach(importClause.namedBindings.elements, checkImportBinding);`
	`24471`	`+ }`
`24469`	`24472`	`}`
`24470`	`24473`	`}`
`24471`	`24474`	`}`