fixUnusedIdentifier: fix "Remove variable statement" codefix (microsoft#24497)

vpukhanov · Andy · commit 75f20f9b65b6 · 2018-05-30T14:51:08.000-07:00
* fixUnusedIdentifier: fix "Remove variable statement" codefix

* Add test for a single "Remove variable statement" codefix in a file
diff --git a/src/services/codefixes/fixUnusedIdentifier.ts b/src/services/codefixes/fixUnusedIdentifier.ts
@@ -29,7 +29,7 @@ namespace ts.codefix {
             }
             const delVar = textChanges.ChangeTracker.with(context, t => tryDeleteFullVariableStatement(t, sourceFile, startToken, /*deleted*/ undefined));
             if (delVar.length) {
-                return [createCodeFixAction(fixName, delDestructure, Diagnostics.Remove_variable_statement, fixIdDelete, Diagnostics.Delete_all_unused_declarations)];
+                return [createCodeFixAction(fixName, delVar, Diagnostics.Remove_variable_statement, fixIdDelete, Diagnostics.Delete_all_unused_declarations)];
             }
 
             const token = getToken(sourceFile, textSpanEnd(context.span));
diff --git a/tests/cases/fourslash/codeFixUnusedIdentifier_removeVariableStatement.ts b/tests/cases/fourslash/codeFixUnusedIdentifier_removeVariableStatement.ts
@@ -0,0 +1,14 @@
+/// <reference path='fourslash.ts' />
+
+// @noUnusedLocals: true
+
+////function f() {
+////    let a = 1, b = 2, c = 3;
+////}
+
+verify.codeFix({
+    description: "Remove variable statement",
+    newFileContent:
+`function f() {
+}`,
+});

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ namespace ts.codefix {`
`29`	`29`	`}`
`30`	`30`	`const delVar = textChanges.ChangeTracker.with(context, t => tryDeleteFullVariableStatement(t, sourceFile, startToken, /deleted/ undefined));`
`31`	`31`	`if (delVar.length) {`
`32`		`- return [createCodeFixAction(fixName, delDestructure, Diagnostics.Remove_variable_statement, fixIdDelete, Diagnostics.Delete_all_unused_declarations)];`
	`32`	`+ return [createCodeFixAction(fixName, delVar, Diagnostics.Remove_variable_statement, fixIdDelete, Diagnostics.Delete_all_unused_declarations)];`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`const token = getToken(sourceFile, textSpanEnd(context.span));`