Use getObjectFlags as suggested in previous PR.

DanielRosenwasser · DanielRosenwasser · commit a5b9a4c5ea8a · 2018-06-21T13:52:06.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -10861,13 +10861,15 @@ namespace ts {
             }
 
             function findMatchingTypeReferenceOrTypeAliasReference(source: Type, unionTarget: UnionOrIntersectionType) {
-                if (source.flags & TypeFlags.Object && (source as ObjectType).objectFlags & (ObjectFlags.Reference | ObjectFlags.Anonymous) && unionTarget.flags & TypeFlags.Union) {
+                const sourceObjectFlags = getObjectFlags(source);
+                if (sourceObjectFlags & (ObjectFlags.Reference | ObjectFlags.Anonymous) && unionTarget.flags & TypeFlags.Union) {
                     return find(unionTarget.types, target => {
                         if (target.flags & TypeFlags.Object) {
-                            if ((source as ObjectType).objectFlags & (target as ObjectType).objectFlags & ObjectFlags.Reference) {
+                            const overlapObjFlags = sourceObjectFlags & getObjectFlags(target);
+                            if (overlapObjFlags & ObjectFlags.Reference) {
                                 return (source as TypeReference).target === (target as TypeReference).target;
                             }
-                            if ((source as ObjectType).objectFlags & (target as ObjectType).objectFlags & ObjectFlags.Anonymous) {
+                            if (overlapObjFlags & ObjectFlags.Anonymous) {
                                 return !!(source as AnonymousType).aliasSymbol && (source as AnonymousType).aliasSymbol === (target as AnonymousType).aliasSymbol;
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -10861,13 +10861,15 @@ namespace ts {`
`10861`	`10861`	`}`
`10862`	`10862`
`10863`	`10863`	`function findMatchingTypeReferenceOrTypeAliasReference(source: Type, unionTarget: UnionOrIntersectionType) {`
`10864`		`- if (source.flags & TypeFlags.Object && (source as ObjectType).objectFlags & (ObjectFlags.Reference \| ObjectFlags.Anonymous) && unionTarget.flags & TypeFlags.Union) {`
	`10864`	`+ const sourceObjectFlags = getObjectFlags(source);`
	`10865`	`+ if (sourceObjectFlags & (ObjectFlags.Reference \| ObjectFlags.Anonymous) && unionTarget.flags & TypeFlags.Union) {`
`10865`	`10866`	`return find(unionTarget.types, target => {`
`10866`	`10867`	`if (target.flags & TypeFlags.Object) {`
`10867`		`- if ((source as ObjectType).objectFlags & (target as ObjectType).objectFlags & ObjectFlags.Reference) {`
	`10868`	`+ const overlapObjFlags = sourceObjectFlags & getObjectFlags(target);`
	`10869`	`+ if (overlapObjFlags & ObjectFlags.Reference) {`
`10868`	`10870`	`return (source as TypeReference).target === (target as TypeReference).target;`
`10869`	`10871`	`}`
`10870`		`- if ((source as ObjectType).objectFlags & (target as ObjectType).objectFlags & ObjectFlags.Anonymous) {`
	`10872`	`+ if (overlapObjFlags & ObjectFlags.Anonymous) {`
`10871`	`10873`	`return !!(source as AnonymousType).aliasSymbol && (source as AnonymousType).aliasSymbol === (target as AnonymousType).aliasSymbol;`
`10872`	`10874`	`}`
`10873`	`10875`	`}`