CR feedback

RyanCavanaugh · RyanCavanaugh · commit aa59753fe410 · 2015-06-25T14:02:30.000-07:00
diff --git a/scripts/errorCheck.ts b/scripts/errorCheck.ts
@@ -4,12 +4,15 @@ let async = require('async');
 let glob = require('glob');
 
 fs.readFile('src/compiler/diagnosticMessages.json', 'utf-8', (err, data) => {
-	let messages  = JSON.parse(data);
-	if (err) throw err;
+	if (err) {
+		throw err;
+	}
+	
+	let messages = JSON.parse(data);
 	let keys = Object.keys(messages);
 	console.log('Loaded ' + keys.length + ' errors');
 
-	for(let k of keys) {
+	for (let k of keys) {
 		messages[k]['seen'] = false;
 	}
 
@@ -18,14 +21,13 @@ fs.readFile('src/compiler/diagnosticMessages.json', 'utf-8', (err, data) => {
 	let baseDir = 'tests/baselines/reference/';
 	fs.readdir(baseDir, (err, files) => {
 		files = files.filter(f => f.indexOf('.errors.txt') > 0);
-		console.log('Read ' + files.length + ' baselines');
 		let tasks: Array<(callback: () => void) => void> = [];
 		files.forEach(f => tasks.push(done => {
 			fs.readFile(baseDir + f, 'utf-8', (err, baseline) => {
 				if (err) throw err;
 
 				let g: string[];
-				while(g = errRegex.exec(baseline)) {
+				while (g = errRegex.exec(baseline)) {
 					var errCode = +g[1];
 					let msg = keys.filter(k => messages[k].code === errCode)[0];
 					messages[msg]['seen'] = true;
@@ -38,8 +40,8 @@ fs.readFile('src/compiler/diagnosticMessages.json', 'utf-8', (err, data) => {
 		async.parallelLimit(tasks, 25, done => {
 			console.log('== List of errors not present in baselines ==');
 			let count = 0;
-			for(let k of keys) {
-				if(messages[k]['seen'] !== true) {
+			for (let k of keys) {
+				if (messages[k]['seen'] !== true) {
 					console.log(k);
 					count++;
 				}
@@ -53,30 +55,32 @@ fs.readFile('src/compiler/diagnosticInformationMap.generated.ts', 'utf-8', (err,
 	let errorRegexp = /\s(\w+): \{ code/g;
 	let errorNames: string[] = [];
 	let errMatch: string[];
-	while(errMatch = errorRegexp.exec(data)) {
+	while (errMatch = errorRegexp.exec(data)) {
 		errorNames.push(errMatch[1]);
 	}
 
 	let allSrc: string = '';
 	glob('./src/**/*.ts', {}, (err, files) => {
 		console.log('Reading ' + files.length + ' source files');
-		files.forEach(file => {
-			if (file.indexOf('diagnosticInformationMap.generated.ts') > 0) return;
+		for(let file of files) {
+			if (file.indexOf('diagnosticInformationMap.generated.ts') > 0) {
+				continue;
+			}
 
 			let src = fs.readFileSync(file, 'utf-8');
 			allSrc = allSrc + src;
-		});
+		}
 
 		console.log('Consumed ' + allSrc.length + ' characters of source');
 
 		let count = 0;
 		console.log('== List of errors not used in source ==')
-		errorNames.forEach(errName => {
-			if(allSrc.indexOf(errName) < 0) {
+		for(let errName of errorNames) {
+			if (allSrc.indexOf(errName) < 0) {
 				console.log(errName);
 				count++;
 			}
-		});
+		}
 		console.log(count + ' of ' + errorNames.length + ' errors are not used in source');
 	});
 });
