always create new node array when assigning positions

zhengbli · zhengbli · commit c46a2e7e1b6f · 2017-03-13T12:45:28.000-07:00
diff --git a/src/services/textChanges.ts b/src/services/textChanges.ts
@@ -380,7 +380,7 @@ namespace ts.textChanges {
             return visited;
         }
         // clone nodearray if necessary
-        const nodeArray = visited === nodes ? createNodeArray(visited) : visited;
+        const nodeArray = visited === nodes ? createNodeArray(visited.slice(0)) : visited;
         nodeArray.pos = getPos(nodes);
         nodeArray.end = getEnd(nodes);
         return nodeArray;

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ namespace ts.textChanges {`
`380`	`380`	`return visited;`
`381`	`381`	`}`
`382`	`382`	`// clone nodearray if necessary`
`383`		`- const nodeArray = visited === nodes ? createNodeArray(visited) : visited;`
	`383`	`+ const nodeArray = visited === nodes ? createNodeArray(visited.slice(0)) : visited;`
`384`	`384`	`nodeArray.pos = getPos(nodes);`
`385`	`385`	`nodeArray.end = getEnd(nodes);`
`386`	`386`	`return nodeArray;`