Skip to content

Also export comment converter Node APIs #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 8, 2020 · 0 comments · Fixed by #821
Closed

Also export comment converter Node APIs #820

JoshuaKGoldberg opened this issue Nov 8, 2020 · 0 comments · Fixed by #821
Assignees
@JoshuaKGoldberg
Labels
area: node API Using tslint-to-eslint-config as an npm dependency status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Milestone
2.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Nov 8, 2020 •
edited
Loading

🚀 Feature Request

Following #732 to add a Node API, the next step for angular-eslint/angular-eslint#173 will be to also convert inline tslint:disable comments for users.

Existing Behavior

The convertFileComments method is not exported as a standalone function via the Node API.

Change Proposal

Let's export it!

More specifically: let's export an equivalent to it that takes in a file's content and path, and returns the new equivalent.
@JoshuaKGoldberg JoshuaKGoldberg added area: node API Using tslint-to-eslint-config as an npm dependency status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request labels Nov 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 8, 2020
This was referenced Nov 8, 2020
Merged
Merged
Open
@JoshuaKGoldberg JoshuaKGoldberg added this to the 2.0 milestone Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: node API Using tslint-to-eslint-config as an npm dependency status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Added convertFileComments API typescript-eslint/tslint-to-eslint-config
1 participant
@JoshuaKGoldberg