fix(eslint-plugin): [no-useless-constructor] handle bodyless constructor (#685)

bradzacher · JamesHenry · commit 55e788c818d0 · 2019-07-24T20:34:25.000-04:00
diff --git a/packages/eslint-plugin/src/rules/no-useless-constructor.ts b/packages/eslint-plugin/src/rules/no-useless-constructor.ts
@@ -63,6 +63,7 @@ export default util.createRule<Options, MessageIds>({
         if (
           node.value &&
           node.value.type === AST_NODE_TYPES.FunctionExpression &&
+          node.value.body &&
           checkAccessibility(node) &&
           checkParams(node)
         ) {
diff --git a/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts b/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
@@ -50,6 +50,8 @@ ruleTester.run('no-useless-constructor', rule, {
     'class A extends B { private constructor(foo, bar) { super(bar); } }',
     'class A extends B { public constructor(foo){ super(foo); } }',
     'class A extends B { public constructor(foo){} }',
+    // type definition / overload
+    'class A { constructor(foo); }',
   ],
   invalid: [
     {

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@ ruleTester.run('no-useless-constructor', rule, {`
`50`	`50`	`'class A extends B { private constructor(foo, bar) { super(bar); } }',`
`51`	`51`	`'class A extends B { public constructor(foo){ super(foo); } }',`
`52`	`52`	`'class A extends B { public constructor(foo){} }',`
	`53`	`+ // type definition / overload`
	`54`	`+ 'class A { constructor(foo); }',`
`53`	`55`	`],`
`54`	`56`	`invalid: [`
`55`	`57`	`{`