fix(eslint-plugin): [no-untyped-pub-sig] constructor return (#1231)

bradzacher · web-flow · commit 6cfd468f79df · 2019-11-19T09:57:12.000-08:00
diff --git a/packages/eslint-plugin/src/rules/no-untyped-public-signature.ts b/packages/eslint-plugin/src/rules/no-untyped-public-signature.ts
@@ -106,7 +106,10 @@ export default util.createRule<Options, MessageIds>({
             });
           }
 
-          if (!isReturnTyped(node.value.returnType)) {
+          if (
+            node.kind !== 'constructor' &&
+            !isReturnTyped(node.value.returnType)
+          ) {
             context.report({
               node,
               messageId: 'noReturnType',
diff --git a/packages/eslint-plugin/tests/rules/no-untyped-public-signature.test.ts b/packages/eslint-plugin/tests/rules/no-untyped-public-signature.test.ts
@@ -28,23 +28,23 @@ ruleTester.run('no-untyped-public-signature', rule, {
       code: `
             class A {
                 public b(c: string):void {
-                
+
                 }
             }`,
     },
     {
       code: `
              class A {
                 public b(...c):void {
-                
+
                 }
             }`,
     },
     {
       code: `
              class A {
                 b(c):void {
-                
+
                 }
             }`,
       options: [{ ignoredMethods: ['b'] }],
@@ -71,22 +71,43 @@ ruleTester.run('no-untyped-public-signature', rule, {
       code: `
              class A {
                 b(...c):void {
-                
+
                 }
-                
+
                 d(c):void {
-                
+
                 }
             }`,
       options: [{ ignoredMethods: ['b', 'd'] }],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/1229
+    `
+class Foo {
+  constructor() {}
+}
+    `,
+    `
+class Foo {
+  abstract constructor() {}
+}
+    `,
+    `
+class Foo {
+  constructor(c: string) {}
+}
+    `,
+    `
+class Foo {
+  abstract constructor(c: string) {}
+}
+    `,
   ],
   invalid: [
     //untyped parameter
     {
       code: `class A {
                 public b(c):void {
-                
+
                 }
             }`,
       errors: [{ messageId: 'untypedParameter' }],
@@ -206,5 +227,22 @@ ruleTester.run('no-untyped-public-signature', rule, {
             }`,
       errors: [{ messageId: 'noReturnType' }],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/1229
+    {
+      code: `
+class Foo {
+  constructor(c) {}
+}
+      `,
+      errors: [{ messageId: 'untypedParameter' }],
+    },
+    {
+      code: `
+class Foo {
+  abstract constructor(c) {}
+}
+      `,
+      errors: [{ messageId: 'untypedParameter' }],
+    },
   ],
 });
