fix(eslint-plugin): [promise-function-async] Allow async get/set (#820)

scottohara · bradzacher · commit cddfdca913b1 · 2019-08-23T08:30:51.000-07:00
diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts
@@ -103,6 +103,14 @@ export default util.createRule<Options, MessageIds>({
         return;
       }
 
+      if (
+        node.parent &&
+        node.parent.type === 'Property' &&
+        (node.parent.kind === 'get' || node.parent.kind === 'set')
+      ) {
+        return;
+      }
+
       context.report({
         messageId: 'missingAsync',
         node,
diff --git a/packages/eslint-plugin/tests/rules/promise-function-async.test.ts b/packages/eslint-plugin/tests/rules/promise-function-async.test.ts
@@ -63,6 +63,12 @@ const invalidAsyncModifiers = {
   },
   set asyncGetter(p: Promise<void>) {
     return p;
+  },
+  get asyncGetterFunc() {
+    return async () => new Promise<void>();
+  },
+  set asyncGetterFunc(p: () => Promise<void>) {
+    return p;
   }
 }
     `,

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,12 @@ const invalidAsyncModifiers = {`
`63`	`63`	`},`
`64`	`64`	`set asyncGetter(p: Promise<void>) {`
`65`	`65`	`return p;`
	`66`	`+ },`
	`67`	`+ get asyncGetterFunc() {`
	`68`	`+ return async () => new Promise<void>();`
	`69`	`+ },`
	`70`	`+ set asyncGetterFunc(p: () => Promise<void>) {`
	`71`	`+ return p;`
`66`	`72`	`}`
`67`	`73`	`}`
`68`	`74`	`,