fix(eslint-plugin): support BigInt in restrict-plus-operands rule (#344)

webschik · bradzacher · commit eee6d49bbde8 · 2019-04-11T15:25:03.000-07:00
Fixes #309
diff --git a/packages/eslint-plugin/src/rules/restrict-plus-operands.ts b/packages/eslint-plugin/src/rules/restrict-plus-operands.ts
@@ -54,7 +54,11 @@ export default util.createRule({
 
       const stringType = typeChecker.typeToString(type);
 
-      if (stringType === 'number' || stringType === 'string') {
+      if (
+        stringType === 'number' ||
+        stringType === 'string' ||
+        stringType === 'bigint'
+      ) {
         return stringType;
       }
       return 'invalid';
diff --git a/packages/eslint-plugin/tests/fixtures/tsconfig.json b/packages/eslint-plugin/tests/fixtures/tsconfig.json
@@ -4,6 +4,6 @@
     "module": "commonjs",
     "strict": true,
     "esModuleInterop": true,
-    "lib": ["es2015", "es2017"]
+    "lib": ["es2015", "es2017", "esnext"]
   }
 }
diff --git a/packages/eslint-plugin/tests/rules/restrict-plus-operands.test.ts b/packages/eslint-plugin/tests/rules/restrict-plus-operands.test.ts
@@ -23,6 +23,8 @@ ruleTester.run('restrict-plus-operands', rule, {
     `var foo = parseInt("5.5", 10) + 10;`,
     `var foo = parseFloat("5.5", 10) + 10;`,
     `var foo = 1n + 1n;`,
+    `var foo = BigInt(1) + 1n`,
+    `var foo = 1n; foo + 2n`,
     `
 function test () : number { return 2; }
 var foo = test("5.5", 10) + 10;
@@ -283,5 +285,25 @@ var foo = pair + pair;
         },
       ],
     },
+    {
+      code: `var foo = 1n; foo + 1`,
+      errors: [
+        {
+          messageId: 'notBigInts',
+          line: 1,
+          column: 15,
+        },
+      ],
+    },
+    {
+      code: `var foo = 1; foo + 1n`,
+      errors: [
+        {
+          messageId: 'notBigInts',
+          line: 1,
+          column: 14,
+        },
+      ],
+    },
   ],
 });

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"module": "commonjs",`
`5`	`5`	`"strict": true,`
`6`	`6`	`"esModuleInterop": true,`
`7`		`- "lib": ["es2015", "es2017"]`
	`7`	`+ "lib": ["es2015", "es2017", "esnext"]`
`8`	`8`	`}`
`9`	`9`	`}`