diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx
index c5af830718ce..36059661b4b1 100644
--- a/docs/contributing/Pull_Requests.mdx
+++ b/docs/contributing/Pull_Requests.mdx
@@ -74,4 +74,10 @@ We generally review PRs oldest to newest, unless we consider a newer PR higher p
Once we have reviewed your PR, we will provide any feedback that needs addressing.
If you feel a requested change is wrong, don't be afraid to discuss with us in the comments.
-Once the feedback is addressed, and the PR is reviewed, we'll ensure the branch is up to date with `main`, and merge it for you.
+
+Please post comments as [line comments](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-line-comments-to-a-pull-request) when possible, so that they can be threaded.
+You can [resolve conversations](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#resolving-conversations) on your own when you feel they're resolved - no need to comment explicitly and/or wait for a maintainer.
+
+Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed.
+
+Once the feedback is addressed, and the PR is approved, we'll ensure the branch is up to date with `main`, and merge it for you.
diff --git a/docs/linting/Troubleshooting.mdx b/docs/linting/Troubleshooting.mdx
index cb59af284478..f29eabc12c37 100644
--- a/docs/linting/Troubleshooting.mdx
+++ b/docs/linting/Troubleshooting.mdx
@@ -243,7 +243,7 @@ See [this issue comment](https://github.com/typescript-eslint/typescript-eslint/
### I get `no-unsafe-*` complaints for cross-file changes
-See [Changes to one file are not reflected in linting other files in my IDE](#changes-to-one-file-are-not-reflected-in-linting-other-files-in-my-ide).
+See [Changes to one file are not reflected in linting other files in my IDE](#changes-to-one-file-are-not-reflected-when-linting-other-files-in-my-ide).
Rules such as [`no-unsafe-argument`](https://typescript-eslint.io/rules/no-unsafe-argument), [`no-unsafe-assignment`](https://typescript-eslint.io/rules/no-unsafe-assignment), and [`no-unsafe-call`](https://typescript-eslint.io/rules/no-unsafe-call) are often impacted.
## My linting feels really slow
diff --git a/docs/linting/troubleshooting/Formatting.mdx b/docs/linting/troubleshooting/Formatting.mdx
index 14c9d102dd00..345ac00acf49 100644
--- a/docs/linting/troubleshooting/Formatting.mdx
+++ b/docs/linting/troubleshooting/Formatting.mdx
@@ -6,17 +6,6 @@ title: What About Formatting?
We strongly recommend against using ESLint for formatting.
We strongly recommend using [Prettier](https://prettier.io), [dprint](https://dprint.dev), or an equivalent instead.
-## ESLint Core and Formatting
-
-Per [ESLint's 2020 Changes to Rule Policies blog post](https://eslint.org/blog/2020/05/changes-to-rules-policies#what-are-the-changes):
-
-> Stylistic rules are frozen - we won't be adding any more options to stylistic rules.
-> We've learned that there's no way to satisfy everyone's personal preferences, and most of the rules already have a lot of difficult-to-understand options.
-> Stylistic rules are those related to spacing, conventions, and generally anything that does not highlight an error or a better way to do something.
-
-We support the ESLint team's decision and backing logic to move away from stylistic rules.
-With the exception of bug fixes, no new formatting-related pull requests will be accepted into typescript-eslint.
-
## Formatters vs. Linters
**Formatters** are tools that verify and correct whitespace issues in code, such as spacing and newlines.
@@ -40,7 +29,10 @@ Modern formatters such as Prettier are architected in a way that applies formatt
### Suggested Usage - Prettier
-We recommend using [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) to disable formatting rules in your ESLint configuration.
+Neither typescript-eslint nor ESLint core enable any formatting-related rules in any recommended presets.
+However, some third party plugin configurations may still enable that bad practice.
+
+If you see formatting rules enabled in your ESLint configuration, we recommend using [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) to disable formatting rules in your ESLint configuration.
You can then configure your formatter separately from ESLint.
Using this config by adding it to the end of your `extends`:
@@ -50,6 +42,7 @@ module.exports = {
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
+ 'other-configuration-that-enables-formatting-rules',
// Add this line
'prettier',
],
@@ -59,4 +52,21 @@ module.exports = {
};
```
-Note that even if you don't use `prettier`, you can use `eslint-config-prettier` as it exclusively turns **off** all formatting rules.
+Note that even if you use a formatter other than `prettier`, you can use `eslint-config-prettier` as it exclusively turns **off** all formatting rules.
+
+## ESLint Core and Formatting
+
+Most lint rules fall into one of two to three categories:
+
+- **Logical**: Rules that care about the logic in runtime behavior of code (such as missing `await`s or invalid logical checks).
+- **Stylistic**: Rules that care about style concerns which do impact runtime behavior of code, but generally not logic. These are mostly around naming or which roughly-equivalent syntax constructs to use (such as function declarations vs. arrow functions).
+ - **Formatting**: Stylistic rules that care only about trivia (semicolons, whitespace, etc.) without impacting the runtime behavior of the code. These rules conflict with dedicated formatters such as Prettier.
+
+Per [ESLint's 2020 Changes to Rule Policies blog post](https://eslint.org/blog/2020/05/changes-to-rules-policies#what-are-the-changes), ESLint itself has moved away from _stylistic_ rules, including _formatting_ rules:
+
+> Stylistic rules are frozen - we won't be adding any more options to stylistic rules.
+> We've learned that there's no way to satisfy everyone's personal preferences, and most of the rules already have a lot of difficult-to-understand options.
+> Stylistic rules are those related to spacing, conventions, and generally anything that does not highlight an error or a better way to do something.
+
+We support the ESLint team's decision and backing logic to move away from _formatting_ and _stylistic_ rules.
+With the exception of bug fixes, no new formatting- or stylistic-related pull requests will be accepted into typescript-eslint.
diff --git a/lerna.json b/lerna.json
index 67403d638803..c46061bee816 100644
--- a/lerna.json
+++ b/lerna.json
@@ -1,5 +1,5 @@
{
- "version": "5.54.0",
+ "version": "5.54.1",
"npmClient": "yarn",
"useWorkspaces": true,
"stream": true
diff --git a/packages/ast-spec/CHANGELOG.md b/packages/ast-spec/CHANGELOG.md
index 9150349b77fe..5d5bf8c2a259 100644
--- a/packages/ast-spec/CHANGELOG.md
+++ b/packages/ast-spec/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/ast-spec
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/ast-spec
diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
index 433b1a89093e..9cf100b2c42a 100644
--- a/packages/ast-spec/package.json
+++ b/packages/ast-spec/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/ast-spec",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "Complete specification for the TypeScript-ESTree AST",
"private": true,
"keywords": [
diff --git a/packages/eslint-plugin-internal/CHANGELOG.md b/packages/eslint-plugin-internal/CHANGELOG.md
index 3ec346f82699..70b3dcdab1ec 100644
--- a/packages/eslint-plugin-internal/CHANGELOG.md
+++ b/packages/eslint-plugin-internal/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/eslint-plugin-internal
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/eslint-plugin-internal
diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
index 09b51492d75d..5b8ce8788415 100644
--- a/packages/eslint-plugin-internal/package.json
+++ b/packages/eslint-plugin-internal/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/eslint-plugin-internal",
- "version": "5.54.0",
+ "version": "5.54.1",
"private": true,
"main": "dist/index.js",
"scripts": {
@@ -14,9 +14,9 @@
},
"dependencies": {
"@types/prettier": "*",
- "@typescript-eslint/scope-manager": "5.54.0",
- "@typescript-eslint/type-utils": "5.54.0",
- "@typescript-eslint/utils": "5.54.0",
+ "@typescript-eslint/scope-manager": "5.54.1",
+ "@typescript-eslint/type-utils": "5.54.1",
+ "@typescript-eslint/utils": "5.54.1",
"prettier": "*"
}
}
diff --git a/packages/eslint-plugin-tslint/CHANGELOG.md b/packages/eslint-plugin-tslint/CHANGELOG.md
index b9e83c269700..392b13bcc252 100644
--- a/packages/eslint-plugin-tslint/CHANGELOG.md
+++ b/packages/eslint-plugin-tslint/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/eslint-plugin-tslint
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/eslint-plugin-tslint
diff --git a/packages/eslint-plugin-tslint/package.json b/packages/eslint-plugin-tslint/package.json
index 5df630a93e8d..0db186480772 100644
--- a/packages/eslint-plugin-tslint/package.json
+++ b/packages/eslint-plugin-tslint/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/eslint-plugin-tslint",
- "version": "5.54.0",
+ "version": "5.54.1",
"main": "dist/index.js",
"typings": "src/index.ts",
"description": "ESLint plugin that wraps a TSLint configuration and lints the whole source using TSLint",
@@ -38,7 +38,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/utils": "5.54.0",
+ "@typescript-eslint/utils": "5.54.1",
"lodash": "^4.17.21"
},
"peerDependencies": {
@@ -48,6 +48,6 @@
},
"devDependencies": {
"@types/lodash": "*",
- "@typescript-eslint/parser": "5.54.0"
+ "@typescript-eslint/parser": "5.54.1"
}
}
diff --git a/packages/eslint-plugin/CHANGELOG.md b/packages/eslint-plugin/CHANGELOG.md
index 364c5045a661..c40f186cd4d5 100644
--- a/packages/eslint-plugin/CHANGELOG.md
+++ b/packages/eslint-plugin/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/eslint-plugin
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
diff --git a/packages/eslint-plugin/docs/rules/consistent-type-exports.md b/packages/eslint-plugin/docs/rules/consistent-type-exports.md
index ec15e9fdecb2..57682fc176d4 100644
--- a/packages/eslint-plugin/docs/rules/consistent-type-exports.md
+++ b/packages/eslint-plugin/docs/rules/consistent-type-exports.md
@@ -9,6 +9,8 @@ description: 'Enforce consistent usage of type exports.'
TypeScript allows specifying a `type` keyword on exports to indicate that the export exists only in the type system, not at runtime.
This allows transpilers to drop exports without knowing the types of the dependencies.
+> See [Blog > Consistent Type Exports and Imports: Why and How](/blog/consistent-type-imports-and-exports-why-and-how) for more details.
+
## Examples
diff --git a/packages/eslint-plugin/docs/rules/consistent-type-imports.md b/packages/eslint-plugin/docs/rules/consistent-type-imports.md
index baa41eccda18..ca8a87717409 100644
--- a/packages/eslint-plugin/docs/rules/consistent-type-imports.md
+++ b/packages/eslint-plugin/docs/rules/consistent-type-imports.md
@@ -9,6 +9,8 @@ description: 'Enforce consistent usage of type imports.'
TypeScript allows specifying a `type` keyword on imports to indicate that the export exists only in the type system, not at runtime.
This allows transpilers to drop imports without knowing the types of the dependencies.
+> See [Blog > Consistent Type Exports and Imports: Why and How](/blog/consistent-type-imports-and-exports-why-and-how) for more details.
+
## Options
### `prefer`
diff --git a/packages/eslint-plugin/docs/rules/no-empty-interface.md b/packages/eslint-plugin/docs/rules/no-empty-interface.md
index 699ebccb64a6..64bf24ffe1fa 100644
--- a/packages/eslint-plugin/docs/rules/no-empty-interface.md
+++ b/packages/eslint-plugin/docs/rules/no-empty-interface.md
@@ -42,7 +42,7 @@ interface Bar {
}
// an interface with more than one supertype
-// in this case the interface can be used as a replacement of a union type.
+// in this case the interface can be used as a replacement of an intersection type.
interface Baz extends Foo, Bar {}
```
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
index a4554996878d..5aaf65c6f07a 100644
--- a/packages/eslint-plugin/package.json
+++ b/packages/eslint-plugin/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/eslint-plugin",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "TypeScript plugin for ESLint",
"keywords": [
"eslint",
@@ -44,9 +44,9 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/scope-manager": "5.54.0",
- "@typescript-eslint/type-utils": "5.54.0",
- "@typescript-eslint/utils": "5.54.0",
+ "@typescript-eslint/scope-manager": "5.54.1",
+ "@typescript-eslint/type-utils": "5.54.1",
+ "@typescript-eslint/utils": "5.54.1",
"debug": "^4.3.4",
"grapheme-splitter": "^1.0.4",
"ignore": "^5.2.0",
diff --git a/packages/experimental-utils/CHANGELOG.md b/packages/experimental-utils/CHANGELOG.md
index 109769d79be5..b375c7b96d43 100644
--- a/packages/experimental-utils/CHANGELOG.md
+++ b/packages/experimental-utils/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/experimental-utils
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/experimental-utils
diff --git a/packages/experimental-utils/package.json b/packages/experimental-utils/package.json
index 454bf95bd1ec..1a974e06eb95 100644
--- a/packages/experimental-utils/package.json
+++ b/packages/experimental-utils/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/experimental-utils",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "(Experimental) Utilities for working with TypeScript + ESLint together",
"keywords": [
"eslint",
@@ -38,7 +38,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/utils": "5.54.0"
+ "@typescript-eslint/utils": "5.54.1"
},
"peerDependencies": {
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
diff --git a/packages/parser/CHANGELOG.md b/packages/parser/CHANGELOG.md
index 7d1ad156c14e..b7ce27143852 100644
--- a/packages/parser/CHANGELOG.md
+++ b/packages/parser/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/parser
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/parser
diff --git a/packages/parser/package.json b/packages/parser/package.json
index b45d41e9d77e..abcaaf0c65f2 100644
--- a/packages/parser/package.json
+++ b/packages/parser/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/parser",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "An ESLint custom parser which leverages TypeScript ESTree",
"main": "dist/index.js",
"types": "dist/index.d.ts",
@@ -45,9 +45,9 @@
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
},
"dependencies": {
- "@typescript-eslint/scope-manager": "5.54.0",
- "@typescript-eslint/types": "5.54.0",
- "@typescript-eslint/typescript-estree": "5.54.0",
+ "@typescript-eslint/scope-manager": "5.54.1",
+ "@typescript-eslint/types": "5.54.1",
+ "@typescript-eslint/typescript-estree": "5.54.1",
"debug": "^4.3.4"
},
"devDependencies": {
diff --git a/packages/scope-manager/CHANGELOG.md b/packages/scope-manager/CHANGELOG.md
index c14aa927d858..dee6e258787d 100644
--- a/packages/scope-manager/CHANGELOG.md
+++ b/packages/scope-manager/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/scope-manager
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/scope-manager
diff --git a/packages/scope-manager/package.json b/packages/scope-manager/package.json
index f01c91167e7f..547067d42807 100644
--- a/packages/scope-manager/package.json
+++ b/packages/scope-manager/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/scope-manager",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "TypeScript scope analyser for ESLint",
"keywords": [
"eslint",
@@ -38,12 +38,12 @@
"typecheck": "nx typecheck"
},
"dependencies": {
- "@typescript-eslint/types": "5.54.0",
- "@typescript-eslint/visitor-keys": "5.54.0"
+ "@typescript-eslint/types": "5.54.1",
+ "@typescript-eslint/visitor-keys": "5.54.1"
},
"devDependencies": {
"@types/glob": "*",
- "@typescript-eslint/typescript-estree": "5.54.0",
+ "@typescript-eslint/typescript-estree": "5.54.1",
"glob": "*",
"jest-specific-snapshot": "*",
"make-dir": "*",
diff --git a/packages/type-utils/CHANGELOG.md b/packages/type-utils/CHANGELOG.md
index e6721fead784..3026d655fd59 100644
--- a/packages/type-utils/CHANGELOG.md
+++ b/packages/type-utils/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/type-utils
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
index 73d61621b022..d85f75ba9aa5 100644
--- a/packages/type-utils/package.json
+++ b/packages/type-utils/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/type-utils",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "Type utilities for working with TypeScript + ESLint together",
"keywords": [
"eslint",
@@ -39,13 +39,13 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/typescript-estree": "5.54.0",
- "@typescript-eslint/utils": "5.54.0",
+ "@typescript-eslint/typescript-estree": "5.54.1",
+ "@typescript-eslint/utils": "5.54.1",
"debug": "^4.3.4",
"tsutils": "^3.21.0"
},
"devDependencies": {
- "@typescript-eslint/parser": "5.54.0",
+ "@typescript-eslint/parser": "5.54.1",
"typescript": "*"
},
"peerDependencies": {
diff --git a/packages/types/CHANGELOG.md b/packages/types/CHANGELOG.md
index 6fe05351606d..3ddd28b629cd 100644
--- a/packages/types/CHANGELOG.md
+++ b/packages/types/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/types
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/types
diff --git a/packages/types/package.json b/packages/types/package.json
index 30f5b7e85297..4c8d71c8e278 100644
--- a/packages/types/package.json
+++ b/packages/types/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/types",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "Types for the TypeScript-ESTree AST spec",
"keywords": [
"eslint",
diff --git a/packages/typescript-estree/CHANGELOG.md b/packages/typescript-estree/CHANGELOG.md
index 56670976d688..c175d6624991 100644
--- a/packages/typescript-estree/CHANGELOG.md
+++ b/packages/typescript-estree/CHANGELOG.md
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+
+### Bug Fixes
+
+* **typescript-estree:** do not call export of clearProgramCache ([#6540](https://github.com/typescript-eslint/typescript-eslint/issues/6540)) ([181e705](https://github.com/typescript-eslint/typescript-eslint/commit/181e705887e9e07f0fa28195644cc94e5b4f039d))
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
diff --git a/packages/typescript-estree/package.json b/packages/typescript-estree/package.json
index 5950d0347506..81b87e3f9d8c 100644
--- a/packages/typescript-estree/package.json
+++ b/packages/typescript-estree/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/typescript-estree",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "A parser that converts TypeScript source code into an ESTree compatible form",
"main": "dist/index.js",
"types": "dist/index.d.ts",
@@ -42,8 +42,8 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/types": "5.54.0",
- "@typescript-eslint/visitor-keys": "5.54.0",
+ "@typescript-eslint/types": "5.54.1",
+ "@typescript-eslint/visitor-keys": "5.54.1",
"debug": "^4.3.4",
"globby": "^11.1.0",
"is-glob": "^4.0.3",
diff --git a/packages/typescript-estree/src/clear-caches.ts b/packages/typescript-estree/src/clear-caches.ts
index c223fe852750..aea4d6cf845c 100644
--- a/packages/typescript-estree/src/clear-caches.ts
+++ b/packages/typescript-estree/src/clear-caches.ts
@@ -18,4 +18,4 @@ export function clearCaches(): void {
}
// TODO - delete this in next major
-export const clearProgramCache = clearCaches();
+export const clearProgramCache = clearCaches;
diff --git a/packages/utils/CHANGELOG.md b/packages/utils/CHANGELOG.md
index 9f7e7378309f..106a387ad881 100644
--- a/packages/utils/CHANGELOG.md
+++ b/packages/utils/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/utils
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/utils
diff --git a/packages/utils/package.json b/packages/utils/package.json
index 7ecb05657765..266f24b0c527 100644
--- a/packages/utils/package.json
+++ b/packages/utils/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/utils",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "Utilities for working with TypeScript + ESLint together",
"keywords": [
"eslint",
@@ -41,9 +41,9 @@
"dependencies": {
"@types/json-schema": "^7.0.9",
"@types/semver": "^7.3.12",
- "@typescript-eslint/scope-manager": "5.54.0",
- "@typescript-eslint/types": "5.54.0",
- "@typescript-eslint/typescript-estree": "5.54.0",
+ "@typescript-eslint/scope-manager": "5.54.1",
+ "@typescript-eslint/types": "5.54.1",
+ "@typescript-eslint/typescript-estree": "5.54.1",
"eslint-scope": "^5.1.1",
"eslint-utils": "^3.0.0",
"semver": "^7.3.7"
@@ -52,7 +52,7 @@
"eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
},
"devDependencies": {
- "@typescript-eslint/parser": "5.54.0",
+ "@typescript-eslint/parser": "5.54.1",
"typescript": "*"
},
"funding": {
diff --git a/packages/visitor-keys/CHANGELOG.md b/packages/visitor-keys/CHANGELOG.md
index db49ee72f70b..0b4588c92482 100644
--- a/packages/visitor-keys/CHANGELOG.md
+++ b/packages/visitor-keys/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/visitor-keys
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package @typescript-eslint/visitor-keys
diff --git a/packages/visitor-keys/package.json b/packages/visitor-keys/package.json
index 5a586ac24434..20c6139e741c 100644
--- a/packages/visitor-keys/package.json
+++ b/packages/visitor-keys/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/visitor-keys",
- "version": "5.54.0",
+ "version": "5.54.1",
"description": "Visitor keys used to help traverse the TypeScript-ESTree AST",
"keywords": [
"eslint",
@@ -39,7 +39,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
- "@typescript-eslint/types": "5.54.0",
+ "@typescript-eslint/types": "5.54.1",
"eslint-visitor-keys": "^3.3.0"
},
"devDependencies": {
diff --git a/packages/website-eslint/CHANGELOG.md b/packages/website-eslint/CHANGELOG.md
index e2f8cc219b8b..c8ae691762e0 100644
--- a/packages/website-eslint/CHANGELOG.md
+++ b/packages/website-eslint/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package @typescript-eslint/website-eslint
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
diff --git a/packages/website-eslint/package.json b/packages/website-eslint/package.json
index 19c19c732dd2..4694787fd03d 100644
--- a/packages/website-eslint/package.json
+++ b/packages/website-eslint/package.json
@@ -1,6 +1,6 @@
{
"name": "@typescript-eslint/website-eslint",
- "version": "5.54.0",
+ "version": "5.54.1",
"private": true,
"description": "ESLint which works in browsers.",
"engines": {
@@ -16,19 +16,19 @@
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore"
},
"dependencies": {
- "@typescript-eslint/types": "5.54.0",
- "@typescript-eslint/utils": "5.54.0"
+ "@typescript-eslint/types": "5.54.1",
+ "@typescript-eslint/utils": "5.54.1"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^23.0.0",
"@rollup/plugin-json": "^5.0.0",
"@rollup/plugin-node-resolve": "^15.0.0",
"@rollup/pluginutils": "^5.0.0",
- "@typescript-eslint/eslint-plugin": "5.54.0",
- "@typescript-eslint/parser": "5.54.0",
- "@typescript-eslint/scope-manager": "5.54.0",
- "@typescript-eslint/typescript-estree": "5.54.0",
- "@typescript-eslint/visitor-keys": "5.54.0",
+ "@typescript-eslint/eslint-plugin": "5.54.1",
+ "@typescript-eslint/parser": "5.54.1",
+ "@typescript-eslint/scope-manager": "5.54.1",
+ "@typescript-eslint/typescript-estree": "5.54.1",
+ "@typescript-eslint/visitor-keys": "5.54.1",
"eslint": "*",
"rollup": "^2.75.4",
"rollup-plugin-terser": "^7.0.2",
diff --git a/packages/website/CHANGELOG.md b/packages/website/CHANGELOG.md
index 9769c71d44a9..161814c0d548 100644
--- a/packages/website/CHANGELOG.md
+++ b/packages/website/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [5.54.1](https://github.com/typescript-eslint/typescript-eslint/compare/v5.54.0...v5.54.1) (2023-03-06)
+
+**Note:** Version bump only for package website
+
+
+
+
+
# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
**Note:** Version bump only for package website
diff --git a/packages/website/blog/2023-02-24-consistent-type-exports-and-imports-why-and-how.md b/packages/website/blog/2023-02-24-consistent-type-exports-and-imports-why-and-how.md
new file mode 100644
index 000000000000..2135f6e3b3b5
--- /dev/null
+++ b/packages/website/blog/2023-02-24-consistent-type-exports-and-imports-why-and-how.md
@@ -0,0 +1,189 @@
+---
+authors:
+ - image_url: https://www.joshuakgoldberg.com/img/josh.jpg
+ name: Josh Goldberg
+ title: typescript-eslint Maintainer
+ url: https://github.com/JoshuaKGoldberg
+description: Why enforcing TypeScript imports use the `type` modifier when possible benefits some project setups.
+slug: consistent-type-imports-and-exports-why-and-how
+tags: [typescript, imports, exports, types, transpiling]
+title: 'Consistent Type Imports and Exports: Why and How'
+---
+
+`import` and `export` statements are core features of the JavaScript language.
+They were added as part of the [ECMAScript Modules (ESM)](https://nodejs.org/api/esm.html#modules-ecmascript-modules) specification, and now are generally available in most mainstream JavaScript environments, including all evergreen browsers and Node.js.
+
+When writing TypeScript code with ESM, it can sometimes be desirable to import or export a type only in the type system.
+Code may wish to refer to a _type_, but not actually import or export a corresponding _value_.
+
+For that purpose, TypeScript 3.8 [added type-only imports and exports](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export) to the TypeScript language:
+
+```ts
+import type { SomeThing } from './some-module.js';
+export type { SomeThing };
+```
+
+The key difference with `export type` and `import type` is that they _do not represent runtime code_.
+Attempting to use a _value_ imported as only a _type_ in runtime code will cause a TypeScript error:
+
+```ts twoslash
+import type { SomeThing } from './some-module.js';
+
+new SomeThing();
+// ~~~~~~~~~
+// 'SomeThing' cannot be used as a value
+// because it was imported using 'import type'.
+```
+
+TypeScript 4.5 also added [inline type qualifiers](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#type-modifiers-on-import-names), which allow for indicating that only some specifiers in a statement should be type-system-only:
+
+```ts
+import { type SomeType, SomeValue } from './some-module.js';
+```
+
+Type-only imports and exports are not emitted as runtime code when code is transpiled to JavaScript.
+This brings up two questions:
+
+- Why would you want to use these type-only imports and exports?
+- How can you enforce a project use them whenever necessary?
+
+Let's Dig In!
+
+
+
+## Benefits of Enforcing Type-only Imports/Exports
+
+### Avoiding Unintentional Side Effects
+
+Some modules in code may cause _side effects_: code that is run when the module is imported and causes changes outside the module.
+Common examples of side effects include sending network requests via `fetch` or creating DOM stylesheets.
+
+When projects include modules that cause side effects, the order of module imports matters.
+For example, some projects import the types of side-effect-causing modules in code that needs to run before those side effects.
+
+### Isolated Module Transpilation
+
+Import statements that only import types are generally removed when the TypeScript compiler transpiles TypeScript syntax to JavaScript syntax.
+The built-in TypeScript compiler is able to do so because it includes a type checker that knows which imports are of types and/or values.
+
+But, some projects use transpilers such as Babel, SWC, or Vite that don't have access to type information.
+These transpilers are sometimes referred to as _isolated module transpilers_ because they effectively transpile each module in isolation from other modules.
+Isolated module transpilers can't know whether an import is of a type, a value, or both.
+
+Take this file with exactly three lines of code:
+
+```ts
+// Is SomeThing a class? A type? A variable?
+// Just from this file, we don't know! 😫
+import { SomeThing } from './may-include-side-effects.js';
+```
+
+If that `./may-include-side-effects.js` module includes side effects, keeping or removing the import can have very different runtime behaviors in the project.
+Indicating in code which values are type-only can be necessary for transpilers that don't have access to TypeScript's type system to know whether to keep or remove the import.
+
+```ts
+// Now we know this file's SomeThing is only used as a type.
+// We can remove this import in transpiled JavaScript syntax.
+import type { SomeThing } from './may-include-side-effects.js';
+```
+
+## Enforcing With typescript-eslint
+
+typescript-eslint provides two ESLint rules that can standardize using (or not using) type-only exports and imports:
+
+- [`@typescript-eslint/consistent-type-exports`](/rules/consistent-type-exports): Enforce consistent usage of type exports.
+- [`@typescript-eslint/consistent-type-imports`](/rules/consistent-type-imports): Enforce consistent usage of type imports.
+
+You can enable them in your [ESLint configuration](https://eslint.org/docs/latest/user-guide/configuring):
+
+```json
+{
+ "plugins": ["@typescript-eslint"],
+ "rules": {
+ "@typescript-eslint/consistent-type-exports": "error",
+ "@typescript-eslint/consistent-type-imports": "error"
+ }
+}
+```
+
+With those rules enabled, running ESLint on the following code would produce a lint complaint:
+
+```ts
+import { GetString } from './types.js';
+// All imports in the declaration are only used as types. Use `import type`.
+
+export function getAndLogValue(getter: GetString) {
+ console.log('Value:', getter());
+}
+```
+
+The two rules can auto-fix code to use `type`s as necessary when ESLint is run on the command-line with `--fix` or configured in an editor extension such as the [VSCode ESLint extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint).
+
+For example, the `import` statement from earlier would be auto-fixed to:
+
+```ts
+import type { GetString } from './types.js';
+
+export function getAndLogValue(getter: GetString) {
+ console.log('Value:', getter());
+}
+```
+
+## More Lint Rules
+
+### `import` Plugin Rules
+
+[`eslint-plugin-import`](https://github.com/import-js/eslint-plugin-import) is a handy plugin with rules that validate proper imports.
+Although some of those rules are made redundant by TypeScript, many are still relevant for TypeScript code.
+
+Two of those rules in particular can be helpful for consistent `type` imports:
+
+- [`import/consistent-type-specifier-style`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md): enforces consistent use of top-level vs inline `type` qualifier
+- [`import/no-duplicates`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports): warns against unnecessary duplicate imports (and with the `inline-type-imports` option can work in tandem with `import/consistent-type-specifier-style`).
+
+In conjunction with [`@typescript-eslint/consistent-type-imports`](/rules/consistent-type-imports), [`eslint-plugin-import`](https://github.com/import-js/eslint-plugin-import)'s rules can enforce your imports are always properly qualified and are written in a standard, predictable style (eg always top-level type qualifier or always inline type-qualifier).
+
+### Verbatim Module Syntax
+
+TypeScript 5.0 additionally adds a new [`--verbatimModuleSyntax`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#verbatimmodulesyntax) compiler option.
+`verbatimModuleSyntax` simplifies TypeScript's logic around whether to preserve imports.
+From the TypeScript release notes:
+
+> ...any imports or exports without a type modifier are left around.
+> Anything that uses the type modifier is dropped entirely.
+>
+> ```ts
+> // Erased away entirely.
+> import type { A } from 'a';
+>
+> // Rewritten to 'import { b } from 'bcd';'
+> import { b, type c, type d } from 'bcd';
+>
+> // Rewritten to 'import {} from 'xyz';'
+> import { type xyz } from 'xyz';
+> ```
+>
+> With this new option, what you see is what you get.
+
+`verbatimModuleSyntax` is useful for simplifying transpilation logic around imports - though it does mean that transpiled code such as the may end up with unnecessary import statements.
+The `import { type xyz } from 'xyz';` line from the previous code snippet is an example of this.
+For the rare case of needing to import for side effects, leaving in those statements may be desirable - but for most cases you will not want to leave behind an unnecessary side effect import.
+
+typescript-eslint now provides a [`@typescript-eslint/no-import-type-side-effects`](/rules/no-import-type-side-effects) rule to flag those cases.
+If it detects an import that only imports specifiers with inline `type` qualifiers, it will suggest rewriting the import to use a top-level `type` qualifier:
+
+```diff
+- import { type A } from 'xyz';
++ import type { A } from 'xyz';
+```
+
+## Further Reading
+
+You can read more about the rules' configuration options in their docs pages.
+See [our Getting Started docs](/getting-started) for more information on linting your TypeScript code with typescript-eslint.
+
+## Supporting typescript-eslint
+
+If you enjoyed this blog post and/or or use typescript-eslint, please consider [supporting us on Open Collective](https://opencollective.com/typescript-eslint).
+We're a small volunteer team and could use your support to make the ESLint experience on TypeScript great.
+Thanks! 💖
diff --git a/packages/website/data/sponsors.json b/packages/website/data/sponsors.json
index f7c3f749e9dc..14e57f8fec5d 100644
--- a/packages/website/data/sponsors.json
+++ b/packages/website/data/sponsors.json
@@ -10,42 +10,42 @@
"id": "Nx (by Nrwl)",
"image": "https://images.opencollective.com/nx/0efbe42/logo.png",
"name": "Nx (by Nrwl)",
- "totalDonations": 625000,
+ "totalDonations": 650000,
"website": "https://nx.dev"
},
{
"id": "ESLint",
"image": "https://images.opencollective.com/eslint/96b09dc/logo.png",
"name": "ESLint",
- "totalDonations": 260000,
+ "totalDonations": 275000,
"website": "https://eslint.org/"
},
{
"id": "Hugging Face",
"image": "https://images.opencollective.com/huggingface/5c934ee/logo.png",
"name": "Hugging Face",
- "totalDonations": 200000,
+ "totalDonations": 220000,
"website": "https://huggingface.co"
},
{
"id": "Airbnb",
"image": "https://images.opencollective.com/airbnb/d327d66/logo.png",
"name": "Airbnb",
- "totalDonations": 155800,
+ "totalDonations": 160800,
"website": "https://www.airbnb.com/"
},
{
"id": "GitBook",
"image": "https://images.opencollective.com/gitbook/d35a8e7/logo.png",
"name": "GitBook",
- "totalDonations": 140000,
+ "totalDonations": 150000,
"website": "https://www.gitbook.com"
},
{
"id": "Codecademy",
"image": "https://images.opencollective.com/codecademy/d56a48d/logo.png",
"name": "Codecademy",
- "totalDonations": 130000,
+ "totalDonations": 140000,
"website": "https://codecademy.com"
},
{
@@ -69,6 +69,13 @@
"totalDonations": 114800,
"website": "https://sentry.io/welcome/"
},
+ {
+ "id": "Sourcegraph",
+ "image": "https://images.opencollective.com/sourcegraph/67e40ff/logo.png",
+ "name": "Sourcegraph",
+ "totalDonations": 90000,
+ "website": "https://about.sourcegraph.com"
+ },
{
"id": "EY Doberman",
"image": "https://images.opencollective.com/ey-doberman/b269462/logo.png",
@@ -76,18 +83,11 @@
"totalDonations": 80400,
"website": "https://doberman.co"
},
- {
- "id": "Sourcegraph",
- "image": "https://images.opencollective.com/sourcegraph/67e40ff/logo.png",
- "name": "Sourcegraph",
- "totalDonations": 80000,
- "website": "https://about.sourcegraph.com"
- },
{
"id": "Codiga",
"image": "https://images.opencollective.com/codiga/1065f9f/logo.png",
"name": "Codiga",
- "totalDonations": 60000,
+ "totalDonations": 70000,
"website": "https://www.codiga.io"
},
{
@@ -104,11 +104,18 @@
"totalDonations": 40000,
"website": "https://whitebox.com"
},
+ {
+ "id": "DeepSource",
+ "image": "https://images.opencollective.com/deepsource/0f18cea/logo.png",
+ "name": "DeepSource",
+ "totalDonations": 40000,
+ "website": "https://deepsource.io/"
+ },
{
"id": "STORIS",
"image": "https://images.opencollective.com/storis/dfb0e13/logo.png",
"name": "STORIS",
- "totalDonations": 31500,
+ "totalDonations": 33000,
"website": "https://www.storis.com/"
},
{
@@ -119,11 +126,11 @@
"website": "https://www.monito.com"
},
{
- "id": "DeepSource",
- "image": "https://images.opencollective.com/deepsource/0f18cea/logo.png",
- "name": "DeepSource",
+ "id": "tRPC",
+ "image": "https://images.opencollective.com/trpc/82704a8/logo.png",
+ "name": "tRPC",
"totalDonations": 30000,
- "website": "https://deepsource.io/"
+ "website": "https://trpc.io"
},
{
"id": "revo.js",
@@ -140,17 +147,17 @@
"website": "https://twitter.com/nevir"
},
{
- "id": "tRPC",
- "image": "https://images.opencollective.com/trpc/82704a8/logo.png",
- "name": "tRPC",
- "totalDonations": 20000,
- "website": "https://trpc.io"
+ "id": "kartenmacherei",
+ "image": "https://images.opencollective.com/kartenmacherei/21bfcfb/logo.png",
+ "name": "kartenmacherei",
+ "totalDonations": 18000,
+ "website": "https://celebrate.company"
},
{
"id": "David Johnston",
"image": "https://images.opencollective.com/blacksheepcode/976d69a/avatar.png",
"name": "David Johnston",
- "totalDonations": 16500,
+ "totalDonations": 17000,
"website": "https://blacksheepcode.com"
},
{
@@ -171,14 +178,14 @@
"id": "Evil Martians",
"image": "https://images.opencollective.com/evilmartians/707ab4d/logo.png",
"name": "Evil Martians",
- "totalDonations": 11500,
+ "totalDonations": 12000,
"website": "https://evilmartians.com/"
},
{
"id": "Balsa",
"image": "https://images.opencollective.com/balsa/77de498/logo.png",
"name": "Balsa",
- "totalDonations": 11500,
+ "totalDonations": 12000,
"website": "https://balsa.com"
},
{
diff --git a/packages/website/docusaurusConfig.ts b/packages/website/docusaurusConfig.ts
index ab543e80783e..3d13fc19ed87 100644
--- a/packages/website/docusaurusConfig.ts
+++ b/packages/website/docusaurusConfig.ts
@@ -103,7 +103,7 @@ const themeConfig: ThemeCommonConfig & AlgoliaThemeConfig = {
{
href: githubUrl,
position: 'right',
- className: 'header-github-link',
+ className: 'github-link header-github-link',
'aria-label': 'GitHub repository',
},
],
@@ -121,10 +121,19 @@ const themeConfig: ThemeCommonConfig & AlgoliaThemeConfig = {
{
label: 'Stack Overflow',
href: 'https://stackoverflow.com/questions/tagged/typescript-eslint',
+ className: 'stack-overflow-link social-link-icon',
},
{
label: 'Twitter',
href: 'https://twitter.com/tseslint',
+ rel: 'me noopener',
+ className: 'twitter-link social-link-icon',
+ },
+ {
+ label: 'Mastodon',
+ href: 'https://fosstodon.org/@tseslint',
+ rel: 'me noopener',
+ className: 'mastodon-link social-link-icon',
},
],
},
@@ -133,11 +142,14 @@ const themeConfig: ThemeCommonConfig & AlgoliaThemeConfig = {
items: [
{
label: 'GitHub',
- href: 'https://github.com/typescript-eslint/typescript-eslint',
+ href: githubUrl,
+ rel: 'me noopener',
+ className: 'github-link social-link-icon',
},
{
label: 'Report issue',
- href: 'https://github.com/typescript-eslint/typescript-eslint/issues/new/choose',
+ href: `${githubUrl}/issues/new/choose`,
+ className: 'bug-report-link social-link-icon',
},
],
},
diff --git a/packages/website/package.json b/packages/website/package.json
index 39bac6330625..03506b2f8640 100644
--- a/packages/website/package.json
+++ b/packages/website/package.json
@@ -1,6 +1,6 @@
{
"name": "website",
- "version": "5.54.0",
+ "version": "5.54.1",
"private": true,
"scripts": {
"build": "docusaurus build",
@@ -21,12 +21,12 @@
"@docusaurus/remark-plugin-npm2yarn": "~2.2.0",
"@docusaurus/theme-common": "~2.2.0",
"@mdx-js/react": "1.6.22",
- "@typescript-eslint/parser": "5.54.0",
- "@typescript-eslint/website-eslint": "5.54.0",
+ "@typescript-eslint/parser": "5.54.1",
+ "@typescript-eslint/website-eslint": "5.54.1",
"clsx": "^1.1.1",
"eslint": "*",
"json-schema": "^0.4.0",
- "json-schema-to-typescript": "^11.0.1",
+ "json-schema-to-typescript": "^12.0.0",
"json5": "^2.2.1",
"konamimojisplosion": "^0.5.1",
"lzstring.ts": "^2.0.2",
@@ -48,13 +48,13 @@
"@types/react": "^18.0.9",
"@types/react-helmet": "^6.1.5",
"@types/react-router-dom": "^5.3.3",
- "@typescript-eslint/eslint-plugin": "5.54.0",
+ "@typescript-eslint/eslint-plugin": "5.54.1",
"copy-webpack-plugin": "^11.0.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-react": "^7.29.4",
"eslint-plugin-react-hooks": "^4.5.0",
"globby": "^11.1.0",
- "monaco-editor": "^0.33.0",
+ "monaco-editor": "^0.36.0",
"webpack": "^5.74.0"
},
"browserslist": {
diff --git a/packages/website/src/components/ErrorsViewer.module.css b/packages/website/src/components/ErrorsViewer.module.css
index 22178ae72acd..415e12d55fc7 100644
--- a/packages/website/src/components/ErrorsViewer.module.css
+++ b/packages/website/src/components/ErrorsViewer.module.css
@@ -9,7 +9,6 @@
letter-spacing: 0;
font-feature-settings: 'liga' 0, 'calt' 0;
box-sizing: border-box;
- white-space: break-spaces;
margin: 0;
}
diff --git a/packages/website/src/components/Playground.module.css b/packages/website/src/components/Playground.module.css
index d6189b238f55..9f14c0eee08f 100644
--- a/packages/website/src/components/Playground.module.css
+++ b/packages/website/src/components/Playground.module.css
@@ -53,7 +53,7 @@
}
.tabCode {
- height: calc(100%);
+ height: calc(100% - 32px);
}
.tabStyle {
diff --git a/packages/website/src/components/Playground.tsx b/packages/website/src/components/Playground.tsx
index eabdb63f6721..a972a32b31a1 100644
--- a/packages/website/src/components/Playground.tsx
+++ b/packages/website/src/components/Playground.tsx
@@ -48,7 +48,6 @@ function rangeReducer(
}
return prevState;
}
-
function Playground(): JSX.Element {
const [state, setState] = useHashState({
jsx: false,
@@ -129,6 +128,7 @@ function Playground(): JSX.Element {
split="vertical"
minSize="10%"
defaultSize="50%"
+ pane2Style={{ overflow: 'hidden' }}
>