Skip to content

Bug: [no-misused-promises] bad report loc for methods in object literals #10212

Closed
@kirkwaiblinger

Description

@kirkwaiblinger

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.6.2&showAST=ts&fileType=.ts&code=C4TwDgpgBAEghgZwGoHsCWATAshYALFDKAXigG8AoKKAMwAoBKALigDd0MKBfCigYxQA7BMCgoW8ZBxz5CJclSiIQgvrUbkoPLkA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1i0Dr0GoMkAO4BDaE0jgwAXxBqgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

type HasVoidMethod = {
  f(): void
}

const o: HasVoidMethod = {
  async f() { }
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-misused-promises": "warn"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

const o: HasVoidMethod = {
  async f() { }
//~~~~~~~
}

Actual Result

const o: HasVoidMethod = {
  async f() { }
//       ~~~~~~
}

Additional Info

For methods, should probably underline an explicitly provided return type if present. Otherwise, use the getFunctionHeadLoc utility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions