Skip to content

Bug: [consistent-indexed-object-style] Unsafe autofix with regards to circular references [8.12.1 regression] #10224

Closed
@JavaScriptBach

Description

@JavaScriptBach

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.4.3&fileType=.tsx&code=FAUwHgDg9gTgLgAjgTwiBBZZBhAljAYwFcAbAQxgBVV0BeYBBAHwQCMooSQyA7B5hDyIBbViBj8WAbwQBtAAoJcPBAGc4MZQHMAugC5MOfMXJUaCAL4BuYMAD0dhOGjwk5rHkKkK1NACYEegdGAXZObj5gxhYhUXF7R2iEACUQAlgAEwAedU0eLQAaQ08THxo-AD4rIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6MgeyeUuX0Ra1mAE0QAPRMNocARgCtEZOn0JJ0URNGgdokcGAC%2BIA0A&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

export type MyCircularType =
  | boolean
  | number
  | { [P in string]: MyCircularType };

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/consistent-indexed-object-style": "error"
  },
};

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

This should not be a lint error. The autofix produces code that does not typecheck:


export type MyCircularType =
  | boolean
  | number
  | Record<string, MyCircularType>;

2456: Type alias 'MyCircularType' circularly references itself. 2:13 - 2:27

This appears to be intended behavior, according to microsoft/TypeScript#35164

Actual Result

Autofixed into code that doesn't typecheck:


export type MyCircularType =
  | boolean
  | number
  | Record<string, MyCircularType>;

Additional Info

Probably caused by #10160.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions