Skip to content

Enhancement: [max-params] add option to check overload signatures as well #10293

Closed
@pillowfication

Description

@pillowfication

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/max-params/

Description

Currently the @typescript-eslint/max-params rule only checks implementation signatures. I would like for an option to also check overload signatures which may have a different number of parameters.

Fail

// ❌ Function 'myFunc' has too many parameters (7). Maximum allowed is 4.
myFunc (a, b, c, d, e, f, g);

myFunc (...args) {
  // ...
}

Pass

myFunc (a, b, c);

myFunc (...args) {
  // ...
}

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions