Skip to content

Bug: [@typescript-eslint/no-deprecated] Super call of deprecated constructor is not reported #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
tobbexiv opened this issue Nov 25, 2024 · 1 comment · Fixed by #10397
Closed
4 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@tobbexiv
Copy link

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.6.3&fileType=.tsx&code=MYGwhgzhAECC0G8CwAoa0D0AqL0ACAJgKYAOATkcGAC5EHRYarrAD2AdhNWQK7DWsyACgCUiAL6pJKVKEgwAQtCIAPWuwIx4yNNDadufAcLE706bLggALVjxD0KJQdWgAjHq4KsiMdq1dGZnMIHhIiE2DpaVkOLmgASwMwdmAieABeaHYiAHc4UQBuWINE5NSiJSyc-IUioA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oBNFjpEZAIb5E3dFETRoHaJHBgAviEVA&tsconfig=&tokens=false

Repro Code

class A {
  /** @deprecated */
  constructor() {}
}

class B extends A {
  constructor() {
    /** should report but does not */
    super()
  }
}

const instanceA = new A();
const instanceB = new B();

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-deprecated": "error"
  }
};

tsconfig

{}

Expected Result

The super call in class B is being reported by @typescript-eslint/no-deprecated.

Actual Result

The super call is not reported and therefore usage of the deprecated constructor is not found.

Additional Info

No response

@tobbexiv tobbexiv added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Nov 25, 2024
@JoshuaKGoldberg
Copy link
Member

😄 it has been a steady joy for me to see all the random syntaxes people keep finding for this rule...

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Nov 25, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Dec 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants