Skip to content

Bug: [no-deprecated] doesn't report on shorthand property in an object expression #10545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
ronami opened this issue Dec 23, 2024 · 1 comment · Fixed by #10550
Closed
4 tasks done

Bug: [no-deprecated] doesn't report on shorthand property in an object expression #10545

ronami opened this issue Dec 23, 2024 · 1 comment · Fixed by #10550
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@ronami
Copy link
Member

ronami commented Dec 23, 2024

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=PQKhAIAEBMFMAcBOsDGBDALra4TAFBwoA2ay4KA9gHYDOG4W9AXOPYgJbUDmA3Pvip0GAM0qVwAXnABvfOHDBg4ZPEqIMtCuuQoMxAJ7zGsFifoAafAF8BQ%2BuABGZKbONK2AC0oBXYjlV1BkcfBmhKU2oAcgxjJgwrWyA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oBNFjpEZAIb5E3dFETRoHaJHBgAviEVA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

/** @deprecated */
declare const test: string;

const foo = {
  // reports correctly
  test: test,
}

const bar = {
  // should report but doesn't
  test,
}

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/no-deprecated": "error",
  },
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expected the rule to report, as TypeScript shows this usage as deprecated.

Actual Result

The rule misses to report this.

Additional Info

No response

@ronami ronami added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Dec 23, 2024
@ronami ronami changed the title Bug: [no-deprecated] doesn't report on a shorthand property in an object expression Bug: [no-deprecated] doesn't report on shorthand property in an object expression Dec 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Dec 23, 2024
@JoshuaKGoldberg
Copy link
Member

This rule is the gift that keeps on giving 🙃

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jan 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants