Skip to content

Bug: [prefer-nullish-coalescing] Should not report error #10724

Closed
@tlebreton

Description

@tlebreton

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play#ts=5.7.2&fileType=.tsx&code=GYVwdgxgLglg9mABFApgZygCgG4EMA2IKAXImCALYBGKATogD6LgAmKwMYKLAlKedTqIA3gChEiWiighaSPIRSIAhAF5ViAIwBWRADI9iBURXrmYNhy4tEAfiMETpTQG5RAXyA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUFvcgAQBcBPABxQGNoBLEggWhXioDsCB6E6RAM0WjuYImyABZ1yAewCGSZORYBzdFD7QJ0SODABfENqA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

function test(value: number | undefined): number {
  return value !== 15 && value !== undefined ? value : 1;
}

ESLint Config

module.exports = {
  "rules": {
        "@typescript-eslint/prefer-nullish-coalescing": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

No error to report

Actual Result

Prefer using nullish coalescing operator (??) instead of a ternary expression, as it is simpler to read. 2:10 - 2:57

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions