Skip to content

Bug: [no-unnecessary-template-expression] does not exempt unions of enums in type context #10769

Closed
@kirkwaiblinger

Description

@kirkwaiblinger

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=KYOwrgtgBAouEEYoG8BQUoHkTCgXigHJMA5GQgGlQF9VVRJZ4AmFdKAFQHcB7fIjgHVMlGnQAuATwAOubMEwAnbjwDiPHgBN%2BAAwAkyOJCQAfJpGbUdAblQBjHiADO4qI4XLe6rQC4sOJRVvbQJiMkJbVClZfw8VACEAQxDzRCgzIwhmWwdnV3dA3iTNP3lCnmL%2BACIhTCrrIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1tiacTJTIAhtEK18iALbF4QifQAexaIMocm6KAHcRG8GAC%2BIA0A&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

enum Enum1 {
  One = 'ONE',
}

enum Enum2 {
  Two = 'TWO',
}

type OneOrTwoGood = `${Enum1 | Enum2}`;
const oneOrTwoGood: OneOrTwoGood = 'ONE';

type OneOrTwoBad = Enum1 | Enum2;
const oneOrTwoBad: OneOrTwoBad = "TWO";

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-unnecessary-template-expression": "warn"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expect that the type OneOrTwoGood should not report.

Actual Result

the type OneOrTwoGood does report, and fixes to OneOrTwoBad, which is not the same.

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions