Skip to content

Bug: [unified-signatures] Does not differentiate truly private methods. #10800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
LukeAbby opened this issue Feb 6, 2025 · 0 comments · Fixed by #10806
Closed
4 tasks done

Bug: [unified-signatures] Does not differentiate truly private methods. #10800

LukeAbby opened this issue Feb 6, 2025 · 0 comments · Fixed by #10806
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@LukeAbby
Copy link

LukeAbby commented Feb 6, 2025

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=CYUwxgNghgTiAEkoGdnwKIA8oFsAOECA3gLABQ88yALlNQJZjwDEeM9AbnSALIjUALAPbAAjAAooALngA7AK44ARiBgBKGRyH1gAbnKUadRizadufQSIBMkmQuWqANPCUB%2BGTXayA5hvhaOvpkAL5AA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6WJygM0sQBNaySgHMmAQ3yxoKdFETRoAe2iRwYAL4h1QA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Example {
  static #privateMethod1(a: number): void;
  static #privateMethod2(a: number, b?: string): void;
}

ESLint Config

{
  "rules": {
    "@typescript-eslint/unified-signatures": "error"
  }
}

tsconfig

Expected Result

No error.

Actual Result

These overloads can be combined into one signature with an optional parameter.

Additional Info

No response

@LukeAbby LukeAbby added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 6, 2025
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 6, 2025
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Mar 10, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
2 participants