Skip to content

Repo: Migrate from yarn to pnpm #10891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JamesHenry opened this issue Feb 26, 2025 · 6 comments
Open

Repo: Migrate from yarn to pnpm #10891

JamesHenry opened this issue Feb 26, 2025 · 6 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JamesHenry
Copy link
Member

JamesHenry commented Feb 26, 2025 •
edited
Loading

Suggestion

We (@bradzacher, @JoshuaKGoldberg and I) decided instead of moving to yarn v4, we will migrate to pnpm.

Additional Info

  • As part of the PR, we can switch all intra-package references to use the workspace: protocol, because nx release can delegate to pnpm publish behind the scenes and dynamically swap these references at publish time
@JamesHenry JamesHenry added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Feb 26, 2025
@JamesHenry JamesHenry mentioned this issue Feb 26, 2025
Closed
@kirkwaiblinger kirkwaiblinger mentioned this issue Feb 27, 2025
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Mar 2, 2025
@xaos7991
Copy link
Contributor

xaos7991 commented May 7, 2025

Is it still actual?

@xaos7991
Copy link
Contributor

I've started working on this. Please let me know if there are any recent updates or considerations I should keep in mind.

@JounQin
Copy link
Contributor

JounQin commented May 18, 2025

Why? I love yarn over pnpm: https://x.com/JounQin/status/1920014194629369941.

@JoshuaKGoldberg
Copy link
Member

Why?

I can't find the deeper technical discussion on demand, but a few general reasons:

  • As great as Yarn is, it's pretty configuration-heavy
  • pnpm has a lot of great defaults and workspaces support - e.g. the OP's mention
  • Several of us on the team have been using pnpm for our projects & quite liking it

https://x.com/JounQin/status/1920014194629369941

That looks like a specific bug in pnpm rather than anything intentional & structural, right? From the replies, pnpm/pnpm#7543? I personally haven't experienced that bug.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 19, 2025
Open
@JounQin
Copy link
Contributor

JounQin commented May 19, 2025

That looks like a specific bug in pnpm rather than anything intentional & structural, right?

It's about TypeScript integration.

https://x.com/isukkaw/status/1920031880369352806

https://github.com/orgs/pnpm/discussions/5535

See aslo TypeScript related issues: https://github.com/pnpm/pnpm/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20TypeScript

@JounQin
Copy link
Contributor

JounQin commented May 20, 2025

https://x.com/JounQin/status/1924721715701321764 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JamesHenry @JoshuaKGoldberg @JounQin @xaos7991