Skip to content

Bug: [no-array-constructor] Fixer removes commends between Array and () #11013

Closed as not planned
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.8.2&fileType=.ts&code=PQKgBAhmLGpgI2rAggJzRAnncBjZXMAE0IAoBKIgU0PgDNCBuIgczvAAtCg&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oENppvCtMhybJ8cMvg7R0URH2mRwYAL4gVQA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

/* a */ /* b */ Array /* c */ /* d */ () /* e */ /* f */ ; /* g */ /* h */

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-array-constructor": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

Fixing should produce something with all comments.

Actual Result

/* c */ and /* d */ are dropped

/* a */ /* b */ [] /* e */ /* f */ ; /* g */ /* h */ 

Additional Info

IMO this is a bug because an automated fixer should never remove comments unrelated to the rule's area of logic. See #10994 -> #10994 (comment). The difference between this issue and #10994 is that this is for an automatic fixer, whereas #10994 is for a manual suggestion.

💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginwontfixThis will not be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions