Skip to content

[2.5.0] Lint runs are ~30% slower #1132

Closed
@bradzacher

Description

@bradzacher

Spinning off of discussion in #1126.
Reported by: @doberkofler

I think that this is because of the change in #1083

There are use cases like Vue, or Markdown, wherein we get provided N distinct content strings for the same filename, where N is the number of <script> tags in the vue file, or the number of code blocks in a markdown file.

We used to not trigger a program sync if we hadn't been asked to parse the file yet, but for these use cases, the file contents TS reads are always different to the file contents eslint gives us, so we have to trigger a file sync on the first parse for a file.

I'll need to look at a solution for this, as invalidating the program for every single file in a CLI run for pure JS/TS codebases (when the file contents from eslint === the file contents in ts) is pretty silly.

Metadata

Metadata

Assignees

Labels

package: typescript-estreeIssues related to @typescript-eslint/typescript-estreeperformanceIssues regarding performance

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions