Skip to content

[lines-around-comment] Does not respect interfaces #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yordis opened this issue Oct 28, 2019 · 8 comments · Fixed by #5327
Closed

[lines-around-comment] Does not respect interfaces #1150

yordis opened this issue Oct 28, 2019 · 8 comments · Fixed by #5327
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: new base rule extension New base rule extension required to handle a TS specific case formatting Related to whitespace/bracket formatting. We strongly recommend you use a formatter instead. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@yordis
Copy link

yordis commented Oct 28, 2019

I am not sure where to open this since the rule is not from typescript-eslint but since it only happens with TypeScript interfaces I am looking for direction.

Repro

{
  "rules": {
    "lines-around-comment": [
      "error",
      {
        "beforeBlockComment": true,
        "afterBlockComment": false,
        "beforeLineComment": true,
        "afterLineComment": false,
        "allowBlockStart": true,
        "allowBlockEnd": false,
        "allowObjectStart": true,
        "allowObjectEnd": false,
        "allowArrayStart": true,
        "allowArrayEnd": false,
        "allowClassStart": true,
        "allowClassEnd": false,
      },
    ],
  }
}
// your repro code case

export interface IStartCommandOptions {
  /**
   * This will throw an error using
   */
  dangerouslyDisableHostCheck: boolean;
}

Expected Result
Shouldn't fail using interfaces

Actual Result

error  Expected line before comment  lines-around-comment

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 2.5.0
@typescript-eslint/parser 2.5.0
TypeScript 3.6.4
ESLint 6.6.0
node 10.16.1
npm 6.12.0
@yordis yordis added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Oct 28, 2019
@bradzacher bradzacher added enhancement: new base rule extension New base rule extension required to handle a TS specific case and removed triage Waiting for team members to take a look labels Oct 28, 2019
@d3lm
Copy link

d3lm commented Aug 28, 2020

Any updates on this?

@yubaoquan
Copy link

Fail on enum either

@dkamyshov dkamyshov mentioned this issue Feb 24, 2021
Closed
@nickofthyme nickofthyme mentioned this issue Mar 31, 2021
Merged
@bradrich
Copy link

Interested in the progress of this.

@bradzacher
Copy link
Member

With any issue in opened in this project - it either has a visible progress in the form of an attached PR, or it has no progress.

We are a community run project. The volunteer maintainers spend most of their time triaging issues and reviewing PRs. This means that most issues will not progress unless a member of the community steps up and champions it.

If this issue is important to you - consider being that champion.

If not - please just subscribe to the issue and wait patiently.
Commenting asking for status updates does not bump issue priority in any way and just serves to spam everyone subscribed to the issue.

@bradrich
Copy link

Thank you for that clarification. I apologize and will read your contribution guidelines for future reference.

@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Oct 25, 2021
@royleejr royleejr mentioned this issue Feb 1, 2022
Merged
4 tasks
@bradzacher bradzacher added the formatting Related to whitespace/bracket formatting. We strongly recommend you use a formatter instead. label May 3, 2022
@zkrising
Copy link

Is this still accepting PRs? I might be free to tackle this soon-ish.

@JoshuaKGoldberg
Copy link
Member

Yup, still accepting PRs @zkldi! Go ahead 🙌

@arkflpc arkflpc mentioned this issue May 27, 2022
Closed
@JesuisTong
Copy link
Contributor

Anybody works on this issue?

@chbdetta chbdetta mentioned this issue Jul 9, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement: new base rule extension New base rule extension required to handle a TS specific case formatting Related to whitespace/bracket formatting. We strongly recommend you use a formatter instead. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [lines-around-comment] add extension rule chbdetta/typescript-eslint
9 participants
@yubaoquan @JoshuaKGoldberg @bradrich @yordis @bradzacher @d3lm @zkrising @JesuisTong and others