[return-await] False positive on any return type, e.g. return JSON.parse() #1269

felixfbecker · 2019-11-26T16:53:30Z

Repro

{
  "rules": {
    "@typescript-eslint/return-await": "error"
  }
}

async function fetcher(): Promise<string> {
    const response = await fetch('/.api/graphql')
    const responseBody = await response.text()
    try {
        return JSON.parse(responseBody)
    } catch (error) {
        return responseBody
    }
}

Expected Result

No error, as JSON.parse() does not return a Promise.

Actual Result

Error: returning an awaited promise is required in this context

Additional Info

Versions

package	version
`@typescript-eslint/eslint-plugin`	`2.9.0`
`@typescript-eslint/parser`	`2.9.0`
`TypeScript`	`3.7.2`
`ESLint`	`6.6.0`
`node`	`12`

The text was updated successfully, but these errors were encountered:

bradzacher · 2019-11-26T18:23:55Z

Hmm, I missed this in the PR, but it looks like the rule was built this way to treat any and unknown as awaitable.

This shouldn't be the case (as per the decisions made for promise-function-async).

felixfbecker added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Nov 26, 2019

bradzacher added bug Something isn't working and removed triage Waiting for team members to take a look labels Nov 26, 2019

a-tarasyuk mentioned this issue Nov 26, 2019

fix(eslint-plugin): [return-await] allow Any and Unknown #1270

Merged

bradzacher closed this as completed in #1270 Nov 27, 2019

github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[return-await] False positive on any return type, e.g. return JSON.parse() #1269

[return-await] False positive on any return type, e.g. return JSON.parse() #1269

felixfbecker commented Nov 26, 2019 •

edited

Loading

bradzacher commented Nov 26, 2019

[return-await] False positive on any return type, e.g. return JSON.parse() #1269

[return-await] False positive on any return type, e.g. return JSON.parse() #1269

Comments

felixfbecker commented Nov 26, 2019 • edited Loading

bradzacher commented Nov 26, 2019

felixfbecker commented Nov 26, 2019 •

edited

Loading