feat(typescript-estree): add parserOption to turn on debug logs #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
armano2
reviewed
Jan 8, 2020
armano2
reviewed
Jan 8, 2020
|
The problem is that it's pretty hard to test this, as the code is buried pretty deep in the stack. |
armano2
reviewed
Jan 9, 2020
# Conflicts: # packages/typescript-estree/src/create-program/shared.ts
armano2
reviewed
Jan 13, 2020
| /* | ||
| * enable parsing JSX. For more details, see https://www.typescriptlang.org/docs/handbook/jsx.html | ||
| /** | ||
| * The absolute path to the file being parsed. |
There was a problem hiding this comment.
this is not fully true anymore, relative paths are working to they are converted to cwd + path
| extraFileExtensions?: string[]; | ||
|
|
||
| /** | ||
| * The absolute path to the file being parsed. |
There was a problem hiding this comment.
Suggested change
| * The absolute path to the file being parsed. | |
| * Absolute (or relative to `tsconfigRootDir`) path to the file being parsed. |
This was referenced Feb 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the cli you can do
DEBUG=typescript-eslint:*,eslint:*and it'll turn on all debug logging.However, when debugging things running in an eslint IDE extension, it's hard to get debug information, which can make it really hard to trace bugs.
It's relatively easy for maintainers to go and edit the files in
node_modules, but it's not really a good experience to ask issue reporters to do the same to give us logs.This just adds the following parserOption
debugLevel?: boolean | ('typescript-eslint' | 'eslint' | 'typescript')[]Which lets you turn on debug logging for all of the relevant modules. I opted for an array instead of a number so it's more explicit and easier to fine tune, because each of the modules can dump a tonne of logs.