feat(*): change TypeScript version range to >=3.2.1 <3.4.0 #184
Conversation
|
IMO minor versions can add warnings but not errors. |
|
In my experience it's not that uncommon for your code to not build with a bump in TypeScript version as it finds some new type bugs in your code. I'm assuming that when you bump the version of TypeScript in this library then my code won't be able to be linted? That said, I'm not sure if we need to do a major bump even if technically this is a breaking change (TypeScript doesn't). I think it makes the number bigger than it needs to be. |
|
@aboyton, we are not installing typescript and we are allowing to use https://github.com/typescript-eslint/typescript-eslint#supported-typescript-version |
Sounds great. Ignore me then. Personally I try to keep on the tip as much as I can and so as long as you do too I don't really mind how you name things. Thanks everyone again for all of the work on this. Now to bump to 3.2 to I can start using this :) |
|
It would be nice to be able to silence the warning with an environment variable or something to that effect, though. Running |
|
If no change, can we support both versions? For example, - "typescript": "~3.2.1"
+ "typescript": ">=3.2.1 <3.4.0" |
|
From memory there’s a way to turn the warning off. Can we document that as I’ve had to do it in the past as I had tools that required ESLint to output nothing when nothing was wrong? In the past I’ve wanted to update TypeScript versions faster than this repo has (and so silenced the warning). |
|
I have implemented all the feedback.
|
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=========================================
+ Coverage 96.2% 96.2% +<.01%
=========================================
Files 51 51
Lines 2449 2451 +2
Branches 368 369 +1
=========================================
+ Hits 2356 2358 +2
Misses 48 48
Partials 45 45
|
typescript-eslint/typescript-eslint#184 @typescript-eslint/eslint-plugin has now loosen their requirement for peer dep. And users are now able to disable the warning by specifying `warnOnUnsupportedTypeScriptVersion` in `parserOptions`. So to ease maintenance burden, we should also loosen this restriction.
…escript-eslint#186) * chore: udpate package dependencies * Add typescript-eslint-parser as a direct dependency of the plugin
@typescript-eslint/core-team I always use to do these TypeScript version changes as major version bumps for clarity - regardless of whether or not breaking changes were required.
It seems for 3.3, we do not need any changes.
Do we want to do major bumps only when breaking changes are required? Or also force them for TS version changes?
Bear in mind, a standard user will receive a warning in their console that they are using an unsupported version if they switch between the versions before and after this PR without updating their TypeScript version.